Proposal: Make it easier to use StringComparison & StringComparer with GetHashCode. #19413
Description
Proposed API
- Add API to convert a
StringComparisonto aStringComparer, to avoid bunch of switch-statements in user code (see 'Motivation' section below). - Add
string.GetHashCode(StringComparison)API, to make it easier/more discoverable to get the culture-dependent, case-insensitive, etc. hash of a string. Currently, you have to doStringComparer.XXX.GetHashCode(str), which is verbose & hard to find.
public class StringComparer
{
public static StringComparer FromComparison(StringComparison comparisonType);
}
public sealed class String
{
public int GetHashCode(StringComparison comparisonType);
}Motivation
If someone has a variable comparison they don't have to do a bunch of switch-cases (we'll do them instead):
public static StringComparer FromComparison(StringComparison comparisonType)
{
switch (comparisonType)
{
case StringComparison.Ordinal:
return StringComparer.Ordinal;
case StringComparison.OrdinalIgnoreCase:
return StringComparer.OrdinalIgnoreCase;
...
}
}For more background: See @stephentoub's suggestion in https://github.com/dotnet/corefx/issues/8034#issuecomment-261519913