-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Description
FYI @AndyAyersMS - I suspect this is related to
that added the assert in question at
runtime/src/coreclr/src/jit/codegencommon.cpp
Line 1379 in 5182dad
| assert(op2->AsIntConCommon()->ImmedValCanBeFolded(compiler, addr->OperGet())); |
We can see in the runtime-coreclr crossgen2 pipeline result history,
https://dev.azure.com/dnceng/public/_build?definitionId=674&_a=summary
that in the run before @GrabYourPitchforks' commit of the GetArrayDataReference mop-up change (that broke System.Private.Corelib crossgenning) just a handful of tests failed:
https://dev.azure.com/dnceng/public/_build/results?buildId=475696&view=results
After Levi's commit, we started failing the SPC build in
In the latest runs, we're failing 7 assemblies:
System.Net.WebHeaderCollection.dll
System.Net.HttpListener.dll
System.Text.Encodings.Web.dll
System.Private.Uri.dll
System.Text.RegularExpressions.dll
System.Text.Json.dll
System.Private.CoreLib.dll
[I have a fix for the SPC crossgen failure related to Levi's change but it seems to be also hitting the assert.]
/cc: @dotnet/crossgen-contrib