Skip to content

Split the big jit files to allow better GitHub experience. #13359

@sandreenko

Description

@sandreenko

GitHub doesn't support showing huge files, for example, https://github.com/dotnet/coreclr/blob/master/src/jit/flowgraph.cpp has 25680 lines, but GitHub will show you only the first 14908. And it doesn't show any warning that the shown part is not full.

The same happens with reviewing diffs.

GitHub limits are not clear, https://help.github.com/en/articles/limits-for-viewing-content-and-diffs-in-a-repository tells about 1MB for text files, but flowgraph is smaller, I wrote them a question about code file sizes limits.

Once we get the actual limits we will be able to determinate the list of files that we need to split.

See also disscusion in dotnet/coreclr#26392 (comment).

cc @dotnet/jit-contrib

category:implementation
theme:jit-coding-style
skill-level:beginner
cost:medium

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions