Skip to content

enforce CMake version consistently (currently 7 different ones) #1311

@danmoseley

Description

@danmoseley

The docs in this repo specify we require CMake 3.15.5 for Windows and macOS, and some unspecified version for Linux. Within our CMakeLists.txt's, we variously enforce 6 distinct minimum versions depending on what you build. There is also a set-cmake-path.ps1 that specifies 3.14, and some other ps1 files that do not specify it.

from CMakeLists.txt's:

cmake_minimum_required(VERSION 2.8.12.2)
cmake_minimum_required(VERSION 3.8) # This project is only included on Win32 platforms so we can have a higher CMake version requirement since we already require a newer CMake version on Windows for various reasons.
cmake_minimum_required(VERSION 3.14)
cmake_minimum_required (VERSION 2.6)
cmake_minimum_required (VERSION 2.8.12)
cmake_minimum_required(VERSION 2.4.4)
  67,102:       Throw "This repository requires CMake 3.14. The newest version of CMake installed is $version. Please install CMake 3.14 or newer from http://www.cmake.org/download/ and ensure it is on your path."

@jkoritzinsky @ViktorHofer do we require the same version across all parts of the tree and host platforms? What version(s)?

Once this is clear we can fix documentation and checks.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions