You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Performance: prefer posix_spawn when available (it has provide up to x100 boost on macOS arm64). It's a matter of extending what Prefer posix_spawn on OSX #126063 did by adding || defined(TARGET_MACCATALYST)here:
int32_tSystemNative_IsATty(intptr_tfd)
{
#if defined(TARGET_MACCATALYST)
returnisatty(ToFileDescriptor(fd));
#elif defined(TARGET_IOS) || defined(TARGET_TVOS)
// there is no terminal on these platforms
(void)fd;
return0;
#endif
}
We need to get #126306 merged first and ensure all the MacCatalyst and iOS builds and tests are green.
posix_spawnwhen available (it has provide up to x100 boost on macOS arm64). It's a matter of extending what Prefer posix_spawn on OSX #126063 did by adding|| defined(TARGET_MACCATALYST)here:IsTerminalcheck for MacCatalyst:We never performed the extra configuration on these platforms:
For IsiOSLike platforms:
runtime/src/libraries/System.Diagnostics.Process/src/System.Diagnostics.Process.csproj
Line 14 in 1d46816
We were including:
runtime/src/libraries/System.Diagnostics.Process/src/System.Diagnostics.Process.csproj
Lines 298 to 300 in 1d46816
That was a nop:
runtime/src/libraries/System.Diagnostics.Process/src/System/Diagnostics/Process.ConfigureTerminalForChildProcesses.iOS.cs
Lines 6 to 20 in 1d46816
The fix will be to stop treating MacCatalyst as
iOSLikein the project file:runtime/src/libraries/System.Diagnostics.Process/src/System.Diagnostics.Process.csproj
Line 14 in ab81350
and extend
pal_log.m(context) with sth like:We need to get #126306 merged first and ensure all the MacCatalyst and iOS builds and tests are green.