…ad of Counter (#121045) ## Description Fixes the incorrect implementation of the `dotnet.thread_pool.thread.count` runtime metric. The metric was implemented as a monotonic `Counter` using `CreateObservableCounter`, but according to the [official documentation](https://learn.microsoft.com/en-us/dotnet/core/diagnostics/built-in-metrics-runtime#metric-dotnetthread_poolthreadcount), it should be an `UpDownCounter` since it represents "the number of thread pool threads that currently exist" - a value that can both increase and decrease over time. ## Changes Changed the metric creation from: ```csharp s_meter.CreateObservableCounter( "dotnet.thread_pool.thread.count", () => (long)ThreadPool.ThreadCount, unit: "{thread}", description: "The number of thread pool threads that currently exist."); ``` To: ```csharp s_meter.CreateObservableUpDownCounter( "dotnet.thread_pool.thread.count", () => (long)ThreadPool.ThreadCount, unit: "{thread}", description: "The number of thread pool threads that currently exist."); ``` This aligns the implementation with: - The official Microsoft documentation - The semantic meaning of the metric (thread count can go up or down) - Other similar metrics in the codebase like `dotnet.timer.count` and `dotnet.assembly.count` ## Testing - All 397 existing unit tests pass, including RuntimeMetricsTests - Manual verification confirms the metric now correctly reports as `ObservableUpDownCounter<System.Int64>` - No breaking changes to the metric name or data - only the instrument type changes Fixes #110757  <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>Runtime metrics for ThreadPool ThreadCount is not implemented as UpDownCounter</issue_title> > <issue_description>In the documentation it is mentioned that the ThreadPool ThreadCount metics is of type [UpDownCounter](https://learn.microsoft.com/en-us/dotnet/core/diagnostics/built-in-metrics-runtime#metric-dotnetthread_poolthreadcount) > > But it looks like it is implemented as a Monotonic counter as it uses `CreateObservableCounter` instead of `CreateObservableUpDownCounter` > > https://github.com/dotnet/runtime/blob/6f3f67528f9c1e6fd3b8614aac054286f3b2e7e0/src/libraries/System.Diagnostics.DiagnosticSource/src/System/Diagnostics/Metrics/RuntimeMetrics.cs#L99 > > > Shouldn't it be an UpDownCounter or a Gauge if it is The number of thread pool threads that currently exist?</issue_description> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > <comment_new><author>@tommcdon</author><body> > @noahfalk @tarekgh </body></comment_new> > <comment_new><author>@noahfalk</author><body> > Yeah, that looks like a bug. Thanks for the report @rakeshv1! > cc @samsp-msft > > @tarekgh - mind if I assign this to you?</body></comment_new> > <comment_new><author>@tarekgh</author><body> > I assigned it to myself. @rakeshv1 are you interested in submitting a PR for that? </body></comment_new> > </comments> > </details> Fixes #112077  --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://survey3.medallia.com/?EAHeSx-AP01bZqG0Ld9QLQ). --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>

Verify running MonoAOT Android in library mode #110757

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions