Skip to content

Switch recognition should not be lexical #107076

New issue
New issue
Closed
#110253
Closed
Switch recognition should not be lexical#107076
#110253
Assignees
amanasifkhalid
Labels
area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIin-prThere is an active PR which will close this issue when it is merged
Milestone
10.0.0
@jakobbotsch

Description

@jakobbotsch
jakobbotsch
opened on Aug 28, 2024

runtime/src/coreclr/jit/switchrecognition.cpp

Lines 172 to 173 in 7ff684a

// Now walk the next blocks and see if they are basically the same type of test
for (const BasicBlock* currBb = firstBlock->Next(); currBb != nullptr; currBb = currBb->Next())

The switch recognition is currently lexical for (from what I can tell) no good reason. Instead, it seems we should be able to recognize any chain of comparisons by following the "did not equal" target.

cc @dotnet/jit-contrib @JulieLeeMSFT @EgorBo

Metadata

Metadata

Assignees

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMIin-prThere is an active PR which will close this issue when it is merged

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions