Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: fe99c44
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a0cc4ea
Choose a head ref
  • 17 commits
  • 82 files changed
  • 19 contributors

Commits on Aug 25, 2022

  1. Add NuGet package for System.Runtime.Serialization.Schema (#74597)

    System.Runtime.Serialization.Schema isn't getting a NuGet package created for it because it doesn't set IsPackable=true.
    
    Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
    github-actions[bot] and eerhardt authored Aug 25, 2022
    Configuration menu
    Copy the full SHA
    3f9a51a View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2022

  1. Configuration menu
    Copy the full SHA
    06aceb7 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. [release/7.0] Use System.Numerics.IEqualityOperators.op_Equality in S…

    …panHelper.T.cs where possible. (#74738)
    
    * Use System.Numerics.IEqualityOperators.op_Equality in SpanHelper.T.cs.
    
    Workaround crash hit by #74179
    making sure we avoid hitting codepath emitting this null pointer checks.
    The full fix includes codegen fixes as well, but will be performed
    in separate PR. There are still locations in SpanHelper.T.cs that uses
    Equal virtual call on value types that could be managed pointers to
    value types, but that code has remained the same for the last
    4 years to 15 months and have not hit this issue in the past.
    
    * Re-enable globalization tests disabled in #74433.
    
    Co-authored-by: lateralusX <lateralusx.github@gmail.com>
    github-actions[bot] and lateralusX authored Aug 29, 2022
    Configuration menu
    Copy the full SHA
    099304f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bdb78f4 View commit details
    Browse the repository at this point in the history
  3. [release/7.0] [NativeAOT] do not do shutdown for the main thread on W…

    …indows (#74712)
    
    * do not do shutdown for the main thread
    
    * specialcase the thread that called RhpShutdown instead
    
    Co-authored-by: vsadov <8218165+VSadov@users.noreply.github.com>
    github-actions[bot] and VSadov authored Aug 29, 2022
    Configuration menu
    Copy the full SHA
    dff9c90 View commit details
    Browse the repository at this point in the history
  4. [release/7.0] Fix signature for 64-bit delegate profiling helper (#74743

    )
    
    * Fix signature for 64-bit delegate profiling helper
    
    I missed updating the signature of the 64-bit variant here when the
    vtable and delegate profiling helpers were originally split up.
    
    Fix #74295
    
    * JIT: Randomly collect 64-bit counts
    
    Add some testing.
    
    * Disable collecting 64 bit counters on 32-bit
    
    This needs some work so disable it for now.
    
    Co-authored-by: Jakob Botsch Nielsen <jakob.botsch.nielsen@gmail.com>
    github-actions[bot] and jakobbotsch authored Aug 29, 2022
    Configuration menu
    Copy the full SHA
    6fa754e View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Move distributed transaction test to OleTxTests (#74748)

    NonMsdtcPromoterTests.PSPENonMsdtcGetPromoterTypeMSDTC was triggering
    an MSDTC distributed transaction on Windows, but without the proper
    checks/resiliency. Moved to OleTxTests.
    
    Fixes #74170
    
    Co-authored-by: Shay Rojansky <roji@roji.org>
    github-actions[bot] and roji authored Aug 30, 2022
    Configuration menu
    Copy the full SHA
    5b15f27 View commit details
    Browse the repository at this point in the history
  2. Discourage using explicit package references to ILCompiler to publish (

    …#74591) (#74769)
    
    * Show a warning when an explicit package reference to ILCompiler is added
    
    * Apply suggestions from code review
    
    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    
    * Fix issue 27239
    
    * Apply suggestions from code review
    
    Co-authored-by: Sven Boemer <sbomer@gmail.com>
    
    * exclude the warning for direct targets file invoke cases
    
    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    Co-authored-by: Sven Boemer <sbomer@gmail.com>
    
    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    Co-authored-by: Sven Boemer <sbomer@gmail.com>
    3 people authored Aug 30, 2022
    Configuration menu
    Copy the full SHA
    6f3db06 View commit details
    Browse the repository at this point in the history
  3. [release/7.0] [wasm][debugger] Fix chinese character in project name (#…

    …74816)
    
    * Fix chinese character in project name
    
    * Adding more tests as suggested by @radical Renaming variable as suggested by @radical
    
    * Update src/mono/wasm/debugger/tests/debugger-test-chinese-char-in-path-ㄨ/debugger-test-chinese-char-in-path-ㄨ.csproj
    
    Co-authored-by: Thays Grazia <thaystg@gmail.com>
    Co-authored-by: Ankit Jain <radical@gmail.com>
    3 people authored Aug 30, 2022
    Configuration menu
    Copy the full SHA
    824c902 View commit details
    Browse the repository at this point in the history
  4. Update THIRD-PARTY-NOTICES file (#74760)

    * Update THIRD-PARTY-NOTICES file
    
    * Remove duplicates
    NikolaMilosavljevic authored Aug 30, 2022
    Configuration menu
    Copy the full SHA
    c027fa8 View commit details
    Browse the repository at this point in the history
  5. [release/7.0] [NativeAOT] enable background GC on Unix (#74772)

    * enable for unix+arm64
    
    * include softwarewritewatch.cpp
    
    * make the unix crst recursive
    
    * enable ww on Unix x64
    
    * enabled card bundles
    
    * comment
    
    Co-authored-by: vsadov <8218165+VSadov@users.noreply.github.com>
    github-actions[bot] and VSadov authored Aug 30, 2022
    Configuration menu
    Copy the full SHA
    b705274 View commit details
    Browse the repository at this point in the history
  6. Fix TransactionInterop.GetDtcTransaction() (#74821)

    Incorrect COM interop definition
    
    Fixes #74745
    
    Co-authored-by: Shay Rojansky <roji@roji.org>
    github-actions[bot] and roji authored Aug 30, 2022
    Configuration menu
    Copy the full SHA
    370a238 View commit details
    Browse the repository at this point in the history
  7. [release/7.0] Fix incorrect "illegal XML comment chars" check & add r…

    …egression tests (#74823)
    
    * Fix incorrect "illegal XML comment chars" check Also adds regression tests
    
    * Rename test method argument
    
    Co-authored-by: Levi Broderick <levib@microsoft.com>
    github-actions[bot] and GrabYourPitchforks authored Aug 30, 2022
    Configuration menu
    Copy the full SHA
    db22ec5 View commit details
    Browse the repository at this point in the history
  8. Merge pull request #74692 from dotnet-maestro-bot/merge/release/7.0-r…

    …c1-to-release/7.0
    
    [automated] Merge branch 'release/7.0-rc1' => 'release/7.0'
    carlossanlop authored Aug 30, 2022
    Configuration menu
    Copy the full SHA
    c37531f View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. Configuration menu
    Copy the full SHA
    65051a0 View commit details
    Browse the repository at this point in the history
  2. Issue was that if a BGC thread handles a mark stack overflow, but run…

    …s into yet another mark stack overflow on another heap, we set a flag on the region, and the containing heap. However, the BGC handling the other heap may have already decided to move on, and may thus not see the flag. (#74814)
    
    Fix is to set the flag on the heap doing the scan rather than the heap containing the object causing the mark stack stack overflow. The thread handling that heap will indeed recheck the flag and rescan if necessary. This necessitates another change because in the concurrent case, we need each BGC thread to enter mark stack overflow scanning if there was a mark stack overflow on its heap. So we need to propagate the per-heap flag to all the heaps.
    
    Fixed another issue for regions where the small_object_segments local variable in background_process_mark_overflow_internal would be set incorrectly in the non-concurrent case. It would be set to FALSE as soon as all the regions for gen 0 are processed.
    
    Co-authored-by: Peter Sollich <petersol@microsoft.com>
    github-actions[bot] and PeterSolMS authored Aug 31, 2022
    Configuration menu
    Copy the full SHA
    d1a7184 View commit details
    Browse the repository at this point in the history
  3. [release/7.0] Fix two auto-atomicity Regex bugs (#74834)

    * Stop coalescing some adjacent Regex atomic loops
    
    We walk concatenations in order to combine adjacent loops, e.g. `a+a+a+` becomes `a{3,}`.  We also combine loops with individual items that are compatible, e.g. `a+ab` becomes `a{2,}b`. However, we're doing these operations on atomic loops as well, which is sometimes wrong. Since an atomic loop consumes as much as possible and never gives anything back, combining it with a subsequent loop will end up essentially ignoring any minimum specified in the latter loop. We thus can't combine atomic loops if the second loop has a minimum; this includes the case where the second "loop" is just an individual item.
    
    * Fix auto-atomicity handling of \w and \b
    
    We currently consider \w and \b non-overlapping, which allows a \w loop followed by a \b to be made atomic.  The problem with this is that \b is zero-width, and it could be followed by something that does overlap with the \w. When matching at a location that is a word boundary, it is possible the first loop could give up something that matches the subsequent construct, and thus it can't be made atomic. (We could probably restrict this further to still allow atomicity when the first loop has a non-0 lower bound, but it doesn't appear to be worth the complication.)
    
    * Add a few more tests
    
    Co-authored-by: Stephen Toub <stoub@microsoft.com>
    github-actions[bot] and stephentoub authored Aug 31, 2022
    Configuration menu
    Copy the full SHA
    a0cc4ea View commit details
    Browse the repository at this point in the history
Loading