Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 625fb02
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7d986fa
Choose a head ref
  • 15 commits
  • 81 files changed
  • 14 contributors

Commits on Aug 13, 2022

  1. Allow for null XmlSerialziers when loading pre-gen from mappings. (#7…

    …3827)
    
    * Allow for null XmlSerialziers when loading pre-gen from mappings.
    
    * Update ref signatures as well.
    StephenMolloy authored Aug 13, 2022
    Configuration menu
    Copy the full SHA
    a2b6674 View commit details
    Browse the repository at this point in the history
  2. [wasm] Support parameters of type Enum with icalls (#73817)

    * [wasm] Support parameters of type Enum with icalls, with tests
    * [wasm] WBT: convert sdk path to full, if needed
    
    Co-authored-by: Ankit Jain <radical@gmail.com>
    maraf and radical authored Aug 13, 2022
    Configuration menu
    Copy the full SHA
    75228ac View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f6d2d09 View commit details
    Browse the repository at this point in the history
  4. EnableAOTAnalyzer for Microsoft.Extensions.Hosting (#73853)

    * EnableAOTAnalyzer for Microsoft.Extensions.Hosting
    
    Fix #71654
    
    Plus clean up the interop in GetParentProcess.
    eerhardt authored Aug 13, 2022
    Configuration menu
    Copy the full SHA
    30dc7e7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    27b18b1 View commit details
    Browse the repository at this point in the history
  6. [metadata] Do less initialization in mono_class_is_assignable (#73786)

    * [metadata] Do less initialization in mono_class_is_assignable
    
    Instead of running the full mono_class_init_internal, just initialize
    the supertypes and the interface bitmap.
    
    Add a flag to mono_class_setup_interface_offsets to only publish the
    interface bitmap, not the offsets.
    
    Also move the SRE hack (setting a field in MonoClass to null and
    running mono_class_setup_interface_offsets) to a new function
    mono_class_invalidate_interface_offsets.
    
    Also change the field that the SRE hack uses as a sentinel (used to be
    MonoClass:interfaces_packed, now MonoClass:interface_offsets_packed)
    
    Fixes #68033
    
    * avoid assert in bitmap_only mode
    
    * remove MonoGenericContext need_sync bit
    
       it is never set to TRUE
    
    * ensure gtd is inited when initing a ginst
    
    * remove unused var
    
    * add regression test
    lambdageek authored Aug 13, 2022
    Configuration menu
    Copy the full SHA
    cf26421 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4c26d98 View commit details
    Browse the repository at this point in the history
  8. ignore name mismatch when IgnoreInvalidName is set (#73745)

    * ignore name mismatch when IgnoreInvalidName is set
    
    * remove dead code
    
    * feedback from review
    
    * fix build
    
    * split Configuration.Certificates
    
    * disable win7
    
    * update test
    
    * skip on browser
    wfurt authored Aug 13, 2022
    Configuration menu
    Copy the full SHA
    d54486e View commit details
    Browse the repository at this point in the history
  9. Baseline failing tests (#73888)

    * S,Transactions is a new test with a bunch of COM
    * PasswordDeriveBytes calls into RequiresUnreferencedCode. It used to be lucky. Not anymore because we trim more.
    MichalStrehovsky authored Aug 13, 2022
    Configuration menu
    Copy the full SHA
    f35b96e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    4c24000 View commit details
    Browse the repository at this point in the history
  11. Streamline String.Substring (#73882)

    - Split the one-arg Substring from the two-arg Substring to avoid unnecessary checks in the former
    - Employ the same argument validation checks as Span, and then delegate to a helper that does more detailed checking to throw the right exception
    - Avoid duplicative checks in the body
    - Reorder checks in one-arg overload to do success paths before error paths where possible
    stephentoub authored Aug 13, 2022
    Configuration menu
    Copy the full SHA
    a037f0c View commit details
    Browse the repository at this point in the history
  12. Fix arm64 scalar intrinsic use with small arguments (#73876)

    The code already uses `emitActualTypeSize` in the scalar case;
    this also uses `genActualType` to get the "actual" type of small
    types when deciding the intrinsic base type, used in codegen.
    
    Fixes #73804
    BruceForstall authored Aug 13, 2022
    Configuration menu
    Copy the full SHA
    3478472 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2022

  1. Update dependencies from https://github.com/dotnet/hotreload-utils bu…

    …ild 20220808.2 (#73895)
    
    Microsoft.DotNet.HotReload.Utils.Generator.BuildTool
     From Version 1.1.0-alpha.0.22362.1 -> To Version 1.1.0-alpha.0.22408.2
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Aug 14, 2022
    Configuration menu
    Copy the full SHA
    99abf51 View commit details
    Browse the repository at this point in the history
  2. [wasm-mt] Use asset loading for dotnet.worker.js; update WasmAppBuild…

    …er (#73697)
    
    Enables using asset loading to get the `dotnet.worker.js` file that provides the emscripten pthread worker code.
    Also allows specifying the number of pre-allocated workers that will be created at startup using MSBuild properties.
    
    Fixes #68509 and fixes #68397 and fixes #72606
    
    - Override Emscripten `PThread.allocateUnusedWorker`
       We want to use our own allocateUnusedWorker because we want to load
       `dotnet.worker.js` using our asset loading machinery.
    
       Unfortunately, Emscripten first calls allocateUnusedWorker very early (from
       `PThread.init`) to pre-allocate the pthread worker pool.
    
       So we set Emscripten's own pthread worker pool to size 0 and make our own.  This requires calling `loadWasmModuleToWorker` during our startup because Emscripten deletes their code that normally does it (in "receiveInstance" in "createWasm" in "emscripten/src/preamble.js") when the pthread pool size is 0.
    
       Also added a pthreadPoolSize field to MonoConfig to allow specifying the initial pthread pool size in mono-config.json
    
    - Add `IncludeThreadsWorker` and `PThreadPoolSize` props to WasmAppBuilder
    
       `IncludeThreadsWorker` adds the `"js-module-threads"` asset to the `mono-config.json`
    
       `PThreadPoolSize` can be -1 or >=0 to specify the number of workers that will be pre-allocated at startup for the pthread worker pool.  -1 means use the default compiled into `dotnet.js`
    
    - Reorganize the pthreads TS code by moving `Internals` (access API that digs through Emscripten's pthreads implementation) to its own module. And add types.
    
    - Replace emscripten's `allocateUnusedWorker` function with our own that goes through the asset loading API.
    
    - Update samples
    
    - Set up console proxying for the workers.
       This is done by sending a message from the main thread to the pthread workers with the current `MonoConfig` on our
        dedicated channel.  (This means the proxying is setup asynchronously, so if the worker is busy before it receives the message, it may not start redirecting messages right away).
    
    ---
    
    * [wasm-mt] Override Emscripten PThread.allocateUnusedWorker
    
    We want to use our own allocateUnusedWorker because we want to load `dotnet.worker.js` using our asset loading machinery.
    
    Unfortunately, Emscripten first calls allocateUnusedWorker very early (from `PThread.init`) to pre-allocate the pthread worker pool.
    
    So we set Emscripten's own pthread worker pool to size 0 and make our own.  This requires calling `loadWasmModuleToWorker` during our startup because Emscripten deletes their code that normally does
    it (in "receiveInstance" in "createWasm" in "emscripten/src/preamble.js") when the pthread pool size is 0.
    
    Also added a pthreadPoolSize field to MonoConfig to allow specifying the initial pthread pool size in mono-config.json
    
    * Add IncludeThreadsWorker and PThreadPoolSize props to WasmAppBuilder
    
    IncludeThreadsWorker adds the js-module-threads asset to the mono-config
    
    PThreadPoolSize can be -1 or >=0 to specify the number of workers that will be pre-allocated at startup for the pthread worker pool.  -1 means use the default compiled into dotnet.js
    
    * Move emscripten PThread internals access to a separate module
    
       and add types
    
    * Load js-module-threads asset in replacement allocateUnusedWorker
    
    * Update samples to explicitly enable threading / perftracing
    
       Makes the WasmAppBuilder include the threads worker module
    
    * tighten up Internals types
    
    * apply review feedback
    
    * fix import
    
    * Apply suggestions from code review
    
    * proxy pthread worker messages to websocket, if enabled
    
    use a new MonoThreadMessageApplyMonoConfig message to send the MonoConfig from the main thread to each worker when the workers set up the communication channel to the main thread.
    
    then if the diagnosticTracing property is true, redirect the worker console logging to a websocket.
    
    Fixes #72606
    
    Co-authored-by: Marek Fišera <mara@neptuo.com>
    Co-authored-by: Ankit Jain <radical@gmail.com>
    3 people authored Aug 14, 2022
    Configuration menu
    Copy the full SHA
    88ba045 View commit details
    Browse the repository at this point in the history
  3. [wasm] Misc tests related fixes (#73884)

    * [wasm] Stop running crypto tests with subtlecrypto
    
    * [wasm] Add --web-server-use-cop for samples when running on helix for a threaded build
    
    * [wasm] Makefile, honor V=1 and emit binlog
    
    * [wasm] PInvokeTableGenerator: emit the type name also, for the warning
    
    * [wasm] Improve build for non-default runtime packs
    
    .. by using `MSBuild` task to build them instead of invoking
    `dotnet.sh`.
    - And fix incremental builds
    
    * [wasm] Run smoke tests only for AOT
    
    - Building, and running all the tests for EAT case will help catch
    linker errors that can slip through.
    
    * [wasm] Fix linker errors for tests
    
    Fixes #73901
    radical authored Aug 14, 2022
    Configuration menu
    Copy the full SHA
    7d986fa View commit details
    Browse the repository at this point in the history
Loading