Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1af9cfd
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b3ef656
Choose a head ref
  • 13 commits
  • 132 files changed
  • 13 contributors

Commits on Aug 20, 2022

  1. [release/7.0-rc1] Disable Int128 use in by value ABI scenarios, and f… 

    …ix field layout behavior (#74279)

* First stab at support for proper 128bit integer layout and abi

* Add ABI tests for Int128 covering interesting scenarios

* Fix bugs so that at least Windows Arm64 works

* Add more types to the ABI tester, so that we cover the Int128 scenarios

* Revert changes which attempted to enable by value passing for Int128

* Make Int128 have layout match the expected unmanaged field layout - On Unix platforms (64 bit) use 16 byte alignment - On Arm32 use 8 byte alignment matching the 128 byte vector type - On other Windows platforms the 128 bit integer type isn't defined by the C compiler, but match the behavior of other 128 bit types (16 byte alignment)

Add tests to call down to native that should pass with these rules

- Disable use of Int128 as p/invoke parameter passed by value

* Mark Int128 types as not having a stable abi - This disables use of these types for parameter passing in R2R images

* Address all known issues

* Try to fix PR job

* Should fix the test issues

* Apply suggestions from code review

Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

Co-authored-by: David Wrighton <davidwr@microsoft.com>
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
    @github-actions @davidwrighton @jkoritzinsky
    3 people authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    d9c1700 View commit details
    Browse the repository at this point in the history

  2. Don't NativeAOT crossgen on ARM64 (#74221) 

    Lets us make #72645 a non-blocking-release issue.

We also set NativeAotSupported to false for Mac on the line above. Crossgen2 will still ship NativeAOT compiled on x64 Linux and Windows. R2R+SingleFile+Trimmed elsewhere.

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
    @github-actions @MichalStrehovsky
    github-actions[bot] and MichalStrehovsky authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    39d767a View commit details
    Browse the repository at this point in the history

  3. [release/7.0-rc1] Add a way to suppress all trimming warnings (#74220) 

    * Add a way to suppress all trimming warnings

Fixes #73926.

Also adding AOT analysis suppression for parity.

I didn't port the warning level support because the compat kind of goes beyond that. We can revisit later if needed.

* Update Microsoft.NETCore.Native.targets

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
    @github-actions @MichalStrehovsky
    github-actions[bot] and MichalStrehovsky authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    c7cab43 View commit details
    Browse the repository at this point in the history

  4. Don't track current field of state machines (#74216) 

    Port of dotnet/linker#2979

Fixes #73048.

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
    @github-actions @MichalStrehovsky
    github-actions[bot] and MichalStrehovsky authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    37193fd View commit details
    Browse the repository at this point in the history

  5. [release/7.0] Update arcade to 7.0.0-beta.22418.4 (#74210)

    @hoyosjs
    hoyosjs authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    3c73d4d View commit details
    Browse the repository at this point in the history

  6. [release/7.0-rc1] Fix for Random failures in System.Numerics.Tests.mo… 

    …dpowTest.ModPowAxiom test (#74181)

* Fixed #70330

* Removed pessimistic buffer cleanup

Co-authored-by: sakno <roman.sakno@gmail.com>
    @github-actions @sakno
    github-actions[bot] and sakno authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    e9070dd View commit details
    Browse the repository at this point in the history

  7. [release/7.0-rc1] Disable matching constants for vectors that needs u… 

    …pper half to be save/restore (#74192)

* Revert "Ensure that GT_CNS_VEC is handled in LinearScan::isMatchingConstant (#70171)"

This reverts commit 24f5de4.

* Revert "Revert "Ensure that GT_CNS_VEC is handled in LinearScan::isMatchingConstant (#70171)""

This reverts commit 984120f.

* Add partial save check

* Use the correct register type

Co-authored-by: Kunal Pathak <Kunal.Pathak@microsoft.com>
    @github-actions @kunalspathak
    github-actions[bot] and kunalspathak authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    2b52df8 View commit details
    Browse the repository at this point in the history

  8. [release/7.0-rc1] Add runs for release/7.0* on community architectures ( 

    #74239)

* Add scheduled runs for release/7.0* on community architectures

* Suggestion from Alex, to avoid upkeep churn

* Switch to runtime.yml model - ALL release branch commits get built

Co-authored-by: Jo Shields <joshield@microsoft.com>
Co-authored-by: Jo Shields <directhex@apebox.org>
    @github-actions @directhex
    3 people authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    5477d65 View commit details
    Browse the repository at this point in the history

  9. Prevent awaiting promise that never resolves (#74243) 

    Co-authored-by: Simon Rozsival <simon@rozsival.com>
    @github-actions @simonrozsival
    github-actions[bot] and simonrozsival authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    d8f8be9 View commit details
    Browse the repository at this point in the history

  10. Remove AES and SubtleCrypto from WASM (#74165) (#74246) 

    * Revert 6a02d5d

* Revert relevant parts of 4222e69 and AES pieces of 8f75cc9

* Remove Subtle Crypto interop code

Fix #73858
    @eerhardt
    eerhardt authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    e897e88 View commit details
    Browse the repository at this point in the history

  11. [release/7.0-rc1] Disable failing runtime extra platforms tests (#74264) 

    * Disable tests failing on Android

* Disable test failing on iOS and MacCatalyst

* Disable failing System.Formats.Tar tests on Android

* Fix JIT.Directed aliasing_retbuf test exclusion on Android

* Disable failing TraceSource tests on tvOS

* Remove unnecessary formatting changes

* Fix skipping failing tests on Android

* Skip tests failing on tvOS

* Revert "Disable failing System.Formats.Tar tests on Android"

This reverts commit bfc2958.

* Link to specific issues

Co-authored-by: Simon Rozsival <simon@rozsival.com>
    @github-actions @simonrozsival
    github-actions[bot] and simonrozsival authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    a2e9125 View commit details
    Browse the repository at this point in the history

  12. [release/7.0-rc1] Directory.CreateDirectory: create missing parents u… 

    …sing default UnixFileMode. (#74277)

* Directory.CreateDirectory: create missing parents using default UnixFileMode.

* Simplify TarHelpers.CreateDirectory.

* PR feedback.

* AssertFileModeEquals: don't skip on Android.

* Always overwite directory metadata.

* TarHelpers.Windows: remove CreateDirectory overwriteMetadata.

* Fix Assert indentation.

Co-authored-by: Tom Deseyn <tom.deseyn@gmail.com>
    @github-actions @tmds
    github-actions[bot] and tmds authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    8196f9a View commit details
    Browse the repository at this point in the history

  13. [release/7.0-rc1] [wasm] Unwrap exception when calling entrypoint (#7… 

    …4263)

* Unwrap exception,

* WBT.

Co-authored-by: Marek Fišera <mara@neptuo.com>
    @github-actions @maraf
    github-actions[bot] and maraf authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    b3ef656 View commit details
    Browse the repository at this point in the history
Loading