Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1af9cfd
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 37193fd
Choose a head ref
  • 4 commits
  • 46 files changed
  • 4 contributors

Commits on Aug 20, 2022

  1. [release/7.0-rc1] Disable Int128 use in by value ABI scenarios, and f… 

    …ix field layout behavior (#74279)

* First stab at support for proper 128bit integer layout and abi

* Add ABI tests for Int128 covering interesting scenarios

* Fix bugs so that at least Windows Arm64 works

* Add more types to the ABI tester, so that we cover the Int128 scenarios

* Revert changes which attempted to enable by value passing for Int128

* Make Int128 have layout match the expected unmanaged field layout - On Unix platforms (64 bit) use 16 byte alignment - On Arm32 use 8 byte alignment matching the 128 byte vector type - On other Windows platforms the 128 bit integer type isn't defined by the C compiler, but match the behavior of other 128 bit types (16 byte alignment)

Add tests to call down to native that should pass with these rules

- Disable use of Int128 as p/invoke parameter passed by value

* Mark Int128 types as not having a stable abi - This disables use of these types for parameter passing in R2R images

* Address all known issues

* Try to fix PR job

* Should fix the test issues

* Apply suggestions from code review

Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>

Co-authored-by: David Wrighton <davidwr@microsoft.com>
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
    @github-actions @davidwrighton @jkoritzinsky
    3 people authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    d9c1700 View commit details
    Browse the repository at this point in the history

  2. Don't NativeAOT crossgen on ARM64 (#74221) 

    Lets us make #72645 a non-blocking-release issue.

We also set NativeAotSupported to false for Mac on the line above. Crossgen2 will still ship NativeAOT compiled on x64 Linux and Windows. R2R+SingleFile+Trimmed elsewhere.

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
    @github-actions @MichalStrehovsky
    github-actions[bot] and MichalStrehovsky authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    39d767a View commit details
    Browse the repository at this point in the history

  3. [release/7.0-rc1] Add a way to suppress all trimming warnings (#74220) 

    * Add a way to suppress all trimming warnings

Fixes #73926.

Also adding AOT analysis suppression for parity.

I didn't port the warning level support because the compat kind of goes beyond that. We can revisit later if needed.

* Update Microsoft.NETCore.Native.targets

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
    @github-actions @MichalStrehovsky
    github-actions[bot] and MichalStrehovsky authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    c7cab43 View commit details
    Browse the repository at this point in the history

  4. Don't track current field of state machines (#74216) 

    Port of dotnet/linker#2979

Fixes #73048.

Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
    @github-actions @MichalStrehovsky
    github-actions[bot] and MichalStrehovsky authored Aug 20, 2022
    Configuration menu
    Copy the full SHA
    37193fd View commit details
    Browse the repository at this point in the history
Loading