Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dotnet/runtime
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 014632b2
Choose a base ref
...
head repository: dotnet/runtime
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: a4fe68fc
Choose a head ref
  • 5 commits
  • 80 files changed
  • 7 contributors

Commits on Aug 2, 2024

  1. Configuration menu
    Copy the full SHA
    f120fff View commit details
    Browse the repository at this point in the history
  2. JIT: Added SVE GetFfr, SetFfr, LoadVectorFirstFaulting, GatherVectorF…

    …irstFaulting (#105595)
    
    * Initial work
    
    * FirstFaulting partially works
    
    * Added template
    
    * Trying to test first-faulting behavior
    
    * Using BoundedMemory to test FirstFaulting behavior for LoadVector.
    
    * Fix size in validation
    
    * Added more helper functions. Added conditional select tests for LoadVectorFirstFaulting.
    
    * Added first-faulting behavior tests for GatherVectorFirstFaulting
    
    * Added GetFfr suffix-style APIs
    
    * Fixing GatherVector tests
    
    * Formatting
    
    * Feedback
    
    * Feedback
    
    * Ensure the P/Invokes are blittable
    
    * Fix build
    
    * Remove checking for zeroes after the fault
    
    * Added GatherVectorFirstFaultingVectorBases test template, but currently without the FirstFaulting test. Added SveFfrTest template.
    
    * Mark GetFfr methods as side-effectful
    
    * Verifying expected fault result. Test weaks.
    
    * Fix build
    
    * Add tracking of FFR register
    
    somewhat workable
    
    code cleanup
    
    Remove FFR
    
    Add all the GetFfr*
    
    wip
    
    Work with MskCns() model
    
    Use physReg approach
    
    Remove commented prototypes
    
    working
    
    Remove bunch of unnecessary code
    
    Remove SpecialImport from GetFFR/SetFFR/LoadFirstFaulting
    
    some more code cleanup
    
    some fixup
    
    * Change condition for PhysReg
    
    * jit format
    
    * Fix PoisonPage configuration while creating BoundedMemory
    
    * Use mmap() instead of memalign() for memory allocation
    
    * review feedback
    
    * unspill for LoadVectorFirstFaulting as well
    
    * Show error codes on failing failure
    
    * Feedback
    
    * Feedback
    
    * Feedback
    
    * Feedback
    
    * Handle FFR correctly
    
    * reuse some of the code
    
    * Handle the special effect for SetFfr
    
    * some fixes + test coverage
    
    * do not zero init lvaFfrRegister
    
    * reverted local change
    
    * fix build break
    
    * Fixing flags for OSX
    
    * Fixup unix impl
    
    * Trying to fix build
    
    * Fix osx calls
    
    * Fix unix impl - forgot to use 'value'
    
    * Added default impl
    
    * Updating error messages
    
    * Attempt mprotect to determine which MAP_ANONYMOUS value to use
    
    * Attempt mprotect to determine which MAP_ANONYMOUS value to use
    
    * Add a way to query MAP_ANONYMOUS
    
    * Add a way to query MAP_ANONYMOUS
    
    * trying to figure out cmake reference
    
    * trying to figure out cmake reference
    
    * trying to figure out cmake reference
    
    * forgot to add cpp files
    
    * Use MemoryMappedFile and then use mprotect
    
    * Minor cleanup
    
    * Added XplatVirtualAlloc, hopefully it will work
    
    * Fix build
    
    * Fix build
    
    * Update hwintrinsiccodegenarm64.cpp
    
    * Trying to fix build
    
    * Use SystemNative
    
    * fix pinvoke
    
    * Get rid of writeline
    
    * Add mono check
    
    * Fix misspelled word
    
    * Check for wasm
    
    * Fix build
    
    * Use IsBrowser
    
    * Check IsWasi
    
    * Check IsBrowser a different way
    
    * Check IsMonoRuntime
    
    * Feedback. Check NETFRAMEWORK
    
    * Simplify check
    
    ---------
    
    Co-authored-by: Tanner Gooding <tagoo@outlook.com>
    Co-authored-by: Kunal Pathak <Kunal.Pathak@microsoft.com>
    Co-authored-by: Swapnil Gaikwad <swapnil.gaikwad@arm.com>
    4 people authored Aug 2, 2024
    Configuration menu
    Copy the full SHA
    df09fd1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9390b99 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. Fix field offset not being set for 0-offset (#105894)

    PersistedAssemblyBuilder didn't write field offset correctly when field offset
    was 0. This fixes that, and adds a test to ensure the behaviour is working.
    
    Fixes #105795
    TrueLunacy authored Aug 3, 2024
    Configuration menu
    Copy the full SHA
    1c0ce30 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a4fe68f View commit details
    Browse the repository at this point in the history
Loading