Replace local ResumeThread P/Invoke in ProcessHandlesTests with shared Interop.Kernel32.ResumeThread

Copilot · jkotas · web-flow · commit c5b7d5904e5b · 2026-04-11T14:19:57.000Z
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/e8bb36bc-5c71-4723-a32c-17e87d762370 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>
diff --git a/src/libraries/System.Diagnostics.Process/tests/ProcessHandlesTests.Windows.cs b/src/libraries/System.Diagnostics.Process/tests/ProcessHandlesTests.Windows.cs
@@ -157,7 +157,7 @@ private unsafe int RunWithInvalidHandles(ProcessStartInfo startInfo)
                 // As soon as SafeProcessHandle.WaitForExit* are implemented (#126293), we can use them instead.
                 using Process process = Process.GetProcessById(processInfo.dwProcessId);
 
-                if (ResumeThread(processInfo.hThread) == -1)
+                if (Interop.Kernel32.ResumeThread(processInfo.hThread) == 0xFFFFFFFF)
                 {
                     throw new Win32Exception();
                 }
@@ -183,9 +183,6 @@ private unsafe int RunWithInvalidHandles(ProcessStartInfo startInfo)
             }
         }
 
-        [LibraryImport(Interop.Libraries.Kernel32)]
-        private static partial int ResumeThread(nint hThread);
-
         private static unsafe string GetSafeFileHandleId(SafeFileHandle handle)
         {
             const int MaxPath = 32_767;
diff --git a/src/libraries/System.Diagnostics.Process/tests/System.Diagnostics.Process.Tests.csproj b/src/libraries/System.Diagnostics.Process/tests/System.Diagnostics.Process.Tests.csproj
@@ -71,6 +71,8 @@
              Link="Common\Interop\Windows\Kernel32\Interop.SetConsoleCtrlHandler.cs" />
     <Compile Include="$(CommonPath)Interop\Windows\Kernel32\Interop.GetFinalPathNameByHandle.cs"
              Link="Common\Interop\Windows\Kernel32\Interop.GetFinalPathNameByHandle.cs" />
+    <Compile Include="$(CommonPath)Interop\Windows\Kernel32\Interop.ResumeThread.cs"
+             Link="Common\Interop\Windows\Kernel32\Interop.ResumeThread.cs" />
     <!-- Helpers -->
     <Compile Include="$(CommonTestPath)TestUtilities\System\WindowsTestFileShare.cs" Link="Common\TestUtilities\System\WindowsTestFileShare.cs" />
   </ItemGroup>

Original file line number	Diff line number	Diff line change
`@@ -157,7 +157,7 @@ private unsafe int RunWithInvalidHandles(ProcessStartInfo startInfo)`
`157`	`157`	`// As soon as SafeProcessHandle.WaitForExit* are implemented (#126293), we can use them instead.`
`158`	`158`	`using Process process = Process.GetProcessById(processInfo.dwProcessId);`
`159`	`159`
`160`		`- if (ResumeThread(processInfo.hThread) == -1)`
	`160`	`+ if (Interop.Kernel32.ResumeThread(processInfo.hThread) == 0xFFFFFFFF)`
`161`	`161`	`{`
`162`	`162`	`throw new Win32Exception();`
`163`	`163`	`}`
`@@ -183,9 +183,6 @@ private unsafe int RunWithInvalidHandles(ProcessStartInfo startInfo)`
`183`	`183`	`}`
`184`	`184`	`}`
`185`	`185`
`186`		`- [LibraryImport(Interop.Libraries.Kernel32)]`
`187`		`- private static partial int ResumeThread(nint hThread);`
`188`		`-`
`189`	`186`	`private static unsafe string GetSafeFileHandleId(SafeFileHandle handle)`
`190`	`187`	`{`
`191`	`188`	`const int MaxPath = 32_767;`