Revert ComputeWasmPublishAssets.cs changes that break native/AOT tests

lewing · Copilot · lewing · commit 79c0886e1e8e · 2026-04-02T10:33:18.000-05:00
The SourceType=Discovered/fx path filtering and CopyToPublishDirectory=Never guard in ComputeWasmPublishAssets.cs were too broad - they blocked legitimate linker output replacements, causing mono_wasm_load_runtime crashes in all native build tests. This was already reverted on the main branch PR #126211; apply the same revert to the preview3 backport. The defense-in-depth filter in Browser.targets (excluding CopyToPublishDirectory=Never from _WasmResolvedFilesToPublish) remains - it prevents the items from reaching ComputeWasmPublishAssets in the first place. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
diff --git a/src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/ComputeWasmPublishAssets.cs b/src/tasks/Microsoft.NET.Sdk.WebAssembly.Pack.Tasks/ComputeWasmPublishAssets.cs
@@ -458,21 +458,7 @@ private void ComputeUpdatedAssemblies(
                 filesToRemove.Add(existing);
                 if (!string.Equals(asset.ItemSpec, existing.GetMetadata("FullPath"), StringComparison.Ordinal))
                 {
-                    // Don't replace Framework-materialized assets. These have unique per-project
-                    // paths (from UpdatePackageStaticWebAssets) that must be preserved in multi-client
-                    // hosted scenarios. Replacing them with the ResolvedFileToPublish item (which
-                    // points to the shared SDK/NuGet path) would cause duplicate Identity crashes.
-                    var assetSourceType = asset.GetMetadata("SourceType");
-                    if (!string.Equals(assetSourceType, "Discovered", StringComparison.OrdinalIgnoreCase) ||
-                        asset.ItemSpec.IndexOf(Path.DirectorySeparatorChar + "fx" + Path.DirectorySeparatorChar, StringComparison.OrdinalIgnoreCase) < 0)
-                    {
-                        linkedAssets.Add(asset.ItemSpec, existing);
-                    }
-                    else
-                    {
-                        Log.LogMessage(MessageImportance.Low, "Skipping replacement of Framework-materialized asset '{0}' with '{1}'",
-                            asset.ItemSpec, existing.GetMetadata("FullPath"));
-                    }
+                    linkedAssets.Add(asset.ItemSpec, existing);
                 }
             }
             else
@@ -736,16 +722,6 @@ private void GroupResolvedFilesToPublish(
                 continue;
             }
 
-            // Skip items explicitly marked as not for publish. These should not be used
-            // to replace build-time assets (e.g., Framework-materialized assets that have
-            // unique per-project paths would otherwise be replaced by the raw SDK-path
-            // original, causing duplicate Identity crashes in multi-client hosted scenarios).
-            if (string.Equals(candidate.GetMetadata("CopyToPublishDirectory"), "Never", StringComparison.OrdinalIgnoreCase))
-            {
-                Log.LogMessage(MessageImportance.Low, "Skipping asset '{0}' because CopyToPublishDirectory is 'Never'", candidate.ItemSpec);
-                continue;
-            }
-
             var fileName = candidate.GetMetadata("FileName");
             var extension = candidate.GetMetadata("Extension");
             if (string.Equals(candidate.GetMetadata("AssetType"), "native", StringComparison.Ordinal) && (fileName == "dotnet" || fileName == "dotnet.native") && extension == ".wasm")
