The RCS1172 diagnostic ("Use 'is' operator instead of 'as' operator") should not be reported when doing == null or != null comparisons if the target type overloads the == or != operators.
For example, in the case of the Unity game engine, UnityEngine.Object overloads those operators, so when you compare with null it actually checks if the object was "destroyed" by the engine or not, instead of checking whether the actual reference is null. If we have, say, an instance to a UnityEngine.Object as an interface, and we want to check if the object was destroyed, we can do:
IWhatever instance = ...;
if (instance as UnityEngine.Object == null)
...
But that triggers the RCS1172 diagnostic. Doing this instead:
IWhatever instance = ...;
if (instance is not UnityEngine.Object)
...
Would not have the desired effect when instance is not null but the object was destroyed.
The RCS1172 diagnostic ("Use 'is' operator instead of 'as' operator") should not be reported when doing
== nullor!= nullcomparisons if the target type overloads the==or!=operators.For example, in the case of the Unity game engine,
UnityEngine.Objectoverloads those operators, so when you compare withnullit actually checks if the object was "destroyed" by the engine or not, instead of checking whether the actual reference is null. If we have, say, an instance to aUnityEngine.Objectas an interface, and we want to check if the object was destroyed, we can do:But that triggers the RCS1172 diagnostic. Doing this instead:
Would not have the desired effect when
instanceis notnullbut the object was destroyed.