Add CA1837 Use Environment.ProcessId#3838
Merged
stephentoub merged 2 commits intodotnet:masterfrom Jul 24, 2020
stephentoub:useenvironmentprocessid
Merged
Add CA1837 Use Environment.ProcessId#3838stephentoub merged 2 commits intodotnet:masterfrom stephentoub:useenvironmentprocessid
stephentoub merged 2 commits intodotnet:masterfrom
stephentoub:useenvironmentprocessid
Conversation
mavasani
reviewed
Jul 8, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/UseEnvironmentProcessIdFixer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Jul 8, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/UseEnvironmentProcessIdFixer.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Jul 8, 2020
src/NetAnalyzers/UnitTests/Microsoft.NetCore.Analyzers/Runtime/UseEnvironmentProcessIdTests.cs
Outdated
Show resolved
Hide resolved
mavasani
approved these changes
Jul 8, 2020
mavasani
left a comment
There was a problem hiding this comment.
LGTM. Minor suggestion on handling trivia and potential DFA enhancement as a follow-up change.
Codecov Report
@@ Coverage Diff @@
## master #3838 +/- ##
========================================
Coverage 95.59% 95.59%
========================================
Files 1143 1146 +3
Lines 251432 251683 +251
Branches 15086 15094 +8
========================================
+ Hits 240357 240603 +246
- Misses 9146 9149 +3
- Partials 1929 1931 +2 |
bartonjs
reviewed
Jul 8, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/UseEnvironmentProcessId.cs
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jul 8, 2020
src/NetAnalyzers/UnitTests/Microsoft.NetCore.Analyzers/Runtime/UseEnvironmentProcessIdTests.cs
Outdated
Show resolved
Hide resolved
bartonjs
approved these changes
Jul 8, 2020
Evangelink
reviewed
Jul 8, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
Outdated
Show resolved
Hide resolved
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
Outdated
Show resolved
Hide resolved
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
Outdated
Show resolved
Hide resolved
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Jul 24, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/UseEnvironmentProcessIdFixer.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Jul 24, 2020
src/NetAnalyzers/UnitTests/Microsoft.NetCore.Analyzers/Runtime/UseEnvironmentProcessIdTests.cs
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New API being added for .NET 5 in dotnet/runtime#38908
cc: @bartonjs