Analyzer: Prefer Memory overloads for Stream async Read/Write methods#3497
Merged
carlossanlop merged 14 commits intodotnet:masterfrom Apr 29, 2020
carlossanlop:PreferStreamAsyncMemoryOverloads
Merged
Analyzer: Prefer Memory overloads for Stream async Read/Write methods#3497carlossanlop merged 14 commits intodotnet:masterfrom carlossanlop:PreferStreamAsyncMemoryOverloads
carlossanlop merged 14 commits intodotnet:masterfrom
carlossanlop:PreferStreamAsyncMemoryOverloads
Conversation
carlossanlop
commented
Apr 14, 2020
carlossanlop
commented
Apr 14, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
Outdated
Show resolved
Hide resolved
carlossanlop
commented
Apr 14, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.cs
Outdated
Show resolved
Hide resolved
carlossanlop
commented
Apr 14, 2020
...tAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloadsFixer.cs
Outdated
Show resolved
Hide resolved
carlossanlop
commented
Apr 14, 2020
...rs/UnitTests/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloadsTestBase.cs
Outdated
Show resolved
Hide resolved
carlossanlop
commented
Apr 14, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.cs
Outdated
Show resolved
Hide resolved
carlossanlop
commented
Apr 14, 2020
...s/UnitTests/Microsoft.NetCore.Analyzers/Runtime/PreferStreamReadAsyncMemoryOverloadsTests.cs
Outdated
Show resolved
Hide resolved
carlossanlop
commented
Apr 14, 2020
...rs/UnitTests/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloadsTestBase.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Apr 14, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Apr 14, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Apr 14, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/MicrosoftNetCoreAnalyzersResources.resx
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Apr 14, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Apr 14, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Apr 14, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Apr 14, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Apr 14, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Apr 14, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Apr 14, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Apr 14, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Apr 14, 2020
...s/UnitTests/Microsoft.NetCore.Analyzers/Runtime/PreferStreamReadAsyncMemoryOverloadsTests.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #3497 +/- ##
=========================================
Coverage 95.11% 95.12%
=========================================
Files 1050 1054 +4
Lines 238214 239557 +1343
Branches 15503 15523 +20
=========================================
+ Hits 226579 227872 +1293
- Misses 9918 9952 +34
- Partials 1717 1733 +16 |
…n description as to why the overloads are preferred.
Typo in a unit test.
mavasani
reviewed
Apr 27, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Apr 27, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Apr 27, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Apr 27, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Apr 27, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Apr 27, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Apr 27, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Apr 27, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.cs
Show resolved
Hide resolved
mavasani
reviewed
Apr 28, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Apr 28, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.cs
Outdated
Show resolved
Hide resolved
Author
|
@buyaa-n @stephentoub @bartonjs can I get a sign off from you please, if everything looks good? |
buyaa-n
approved these changes
Apr 28, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/PreferStreamAsyncMemoryOverloads.cs
Outdated
Show resolved
Hide resolved
Co-Authored-By: buyaa-n <buyankhishig.namnan@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to dotnet/runtime#33790
Summary
If the user invokes any of these methods from an object that is or inherits from
Stream:ReadAsync(Byte[], Int32, Int32)ReadAsync(Byte[], Int32, Int32, CancellationToken)WriteAsync(Byte[], Int32, Int32)WriteAsync(Byte[], Int32, Int32, CancellationToken)We should suggest to instead use:
ReadAsync(Memory<Byte>, CancellationToken)WriteAsync(ReadOnlyMemory<Byte>, CancellationToken)All unit tests passed locally.