Codecov Report

Merging #3443 into master will increase coverage by 0.00%.
The diff coverage is 98.40%.

@@           Coverage Diff            @@
##           master    #3443    +/-   ##
========================================
  Coverage   95.27%   95.28%            
========================================
  Files        1006     1009     +3     
  Lines      230946   231260   +314     
  Branches    14921    14939    +18     
========================================
+ Hits       220041   220346   +305     
- Misses       9259     9263     +4     
- Partials     1646     1651     +5     

FYI: You will need to fix a new RS diagnostic once #3444 goes in - should be easy to fix with an IDE code fix.

FYI: You will need to fix a new RS diagnostic once #3444 goes in - should be easy to fix with an IDE code fix.

Done.

I have a question about this PR, @stephentoub:

The original issue was categorized by Immo as "Performance", but this PR adds the analyzer inside the Runtime folder instead of the Performance folder. Why is that?

• Microsoft.CodeAnalysis.NetAnalyzers project
  • Microsoft.NetCore.Analyzers folder
    • Runtime folder <-
    • Performance folder

I have this issue assigned to me to create an analyzer, and was also categorized as "Performance", so I'd like to know how to decide in which folder should I create my analyzer.

The original issue was categorized by Immo as "Performance", but this PR adds the analyzer inside the Runtime folder instead of the Performance folder. Why is that?

The categorization that's important is this one:
https://github.com/dotnet/roslyn-analyzers/pull/3443/files#diff-d6a8b8e17ba2b3ecec87bd042b598259R22
The folder isn't publicly visible for folks consuming the analyzer. I put it in the runtime folder because the general organization of this project is generally around types rather than purpose. But we can always move things between folders as needed. @mavasani, any further advice?

Agree with @stephentoub - the important bit is the category set in the descriptor. Ideally, the folder structure will match the rule category, but it has been out of sync for a while. We have wanted to correct it, but never got to prioritize that work. We can even consider flattening the files into a single folder, i.e. put all analyzers under the folder https://github.com/dotnet/roslyn-analyzers/tree/master/src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers and remove all sub-folders.