Add DoNotUseStackallocInLoopsAnalyzer#3432
Merged
stephentoub merged 1 commit intodotnet:masterfrom Mar 27, 2020
stephentoub:stackallocloops
Merged
Add DoNotUseStackallocInLoopsAnalyzer#3432stephentoub merged 1 commit intodotnet:masterfrom stephentoub:stackallocloops
stephentoub merged 1 commit intodotnet:masterfrom
stephentoub:stackallocloops
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3432 +/- ##
========================================
Coverage 95.26% 95.27%
========================================
Files 1002 1004 +2
Lines 230289 230499 +210
Branches 14875 14882 +7
========================================
+ Hits 219387 219597 +210
Misses 9255 9255
Partials 1647 1647 |
Evangelink
reviewed
Mar 26, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/DoNotUseStackallocInLoops.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Mar 26, 2020
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/DoNotUseStackallocInLoops.cs
Outdated
Show resolved
Hide resolved
mavasani
reviewed
Mar 27, 2020
...NetAnalyzers/UnitTests/Microsoft.NetCore.Analyzers/Runtime/DoNotUseStackallocInLoopsTests.cs
Outdated
Show resolved
Hide resolved
mavasani
approved these changes
Mar 27, 2020
Finds stackallocs used within loops and warns that such stackallocs should be moved out of the loop.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finds stackallocs used within loops and warns that such stackallocs should be moved out of the loop.
Fixes dotnet/runtime#33782
cc: @mavasani, @sharwell, @bartonjs, @jeffhandley