Conversation
…okeUtil.Exec Agent-Logs-Url: https://github.com/dotnet/roslyn/sessions/673c28d8-d3e5-490d-b4e2-caff66247118 Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
jaredpar
April 2, 2026 22:43
View session
Member
|
@RikkiGibson, @333fred, @jjonescz PTAL In another PR I hit a flaky failure in this test method. Decided to see what CCA could do with it and gave it the following prompt: Was really curious if it could reason out a race condition around |
333fred
approved these changes
Apr 3, 2026
RikkiGibson
reviewed
Apr 3, 2026
Member
RikkiGibson
left a comment
There was a problem hiding this comment.
LGTM, just had another conversation going on while I was in the middle of looking up AssertEx.cs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InvokeUtil.ExecsnapshotsCompilerLoadContext.Assembliesbefore running the test, then asserts the set is unchanged afterward.AssertExhas static fields that lazily initialize DiffPlex on first use; when that first use fell between the snapshot and the final comparison, DiffPlex (andMicrosoft.Win32.Registryas anetstandard2.0compat shim on .NET 10) appeared only in the post-test list, failing theSetEqualcheck. OnlyLoadStreamwas affected because the other variants ran in process contexts where a prior test had already triggeredAssertExinitialization.Changes
InvokeUtil.cs: CallRuntimeHelpers.RunClassConstructor(typeof(AssertEx).TypeHandle)before taking thecompilerContextAssembliessnapshot, ensuring DiffPlex and any compat-shim assemblies it pulls in are already present in both sides of the comparison.Microsoft Reviewers: Open in CodeFlow