Skip to content

Fix with-element indentation in collection expressions on multiple lines#83030

Merged
akhera99 merged 3 commits intodotnet:mainfrom
CyrusNajmabadi:withIndentation
Apr 3, 2026
Merged

Fix with-element indentation in collection expressions on multiple lines#83030
akhera99 merged 3 commits intodotnet:mainfrom
CyrusNajmabadi:withIndentation

Conversation

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

@CyrusNajmabadi CyrusNajmabadi commented Apr 2, 2026

Fixes #83029

Should be read commit by commit.

Microsoft Reviewers: Open in CodeFlow

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner April 2, 2026 08:32
@dotnet-policy-service dotnet-policy-service bot added Community The pull request was submitted by a contributor who is not a Microsoft employee. VSCode labels Apr 2, 2026
@CyrusNajmabadi
Copy link
Copy Markdown
Contributor Author

@JoeRobich ptal.

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor Author

@JoeRobich @dibarbet @akhera99 ptal.

""");

[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/83029")]
public Task TestWithOverMultipleLines()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, can you add a test where the HashSet constructor arguments are multi-line?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@akhera99 akhera99 enabled auto-merge (squash) April 2, 2026 20:07
@akhera99 akhera99 merged commit ecefed0 into dotnet:main Apr 3, 2026
24 of 25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. VSCode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"with" element is not correctly indented when converting collection initializer

2 participants