Preserve #: file-based app directives during formatting#82996
Merged
jasonmalinowski merged 2 commits intodotnet:mainfrom Apr 2, 2026
Merged
Preserve #: file-based app directives during formatting#82996jasonmalinowski merged 2 commits intodotnet:mainfrom
jasonmalinowski merged 2 commits intodotnet:mainfrom
Conversation
jasonmalinowski
approved these changes
Apr 2, 2026
Member
|
The one test failure was a random failure, so rerunning. |
RikkiGibson
approved these changes
Apr 2, 2026
Member
|
Thanks @dusrdev for the fix! |
Contributor
Author
|
@jasonmalinowski my pleasure! |
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix C# formatting for file-based app directives parsed as
IgnoredDirectiveTriviaSyntax.When the formatter touches a line like:
Roslyn was rewriting it to:
That breaks file-based app syntax and causes downstream issues such as loss of project/file-based-app recognition and completion failures.
Root cause
File-based app directives are represented as
IgnoredDirectiveTriviaSyntax, butStructuredTriviaFormattingRuledid not preserve spacing for the syntax-significant token sequence:HashToken -> ColonTokenColonToken -> ContentAs a result, generic punctuation spacing rules inserted spaces around
:once the directive line became eligible for formatting.Fix
Add a special-case in
StructuredTriviaFormattingRuleto force zero spaces for:#followed by::followed by the directive contentinside
IgnoredDirectiveTriviaSyntax.Tests
Added formatter coverage for file-based app directives:
#:package ...directive#:package ...form instead of# : package ...This should also fix this vscode-csharp issue
Microsoft Reviewers: Open in CodeFlow