Switch Unix builds to Roslyn.slnx and drive test platform selection via TFM by Copilot · Pull Request #82989 · dotnet/roslyn

Copilot · 2026-03-30T22:42:18Z

This change reworks how our infra decides which tests run on which platform. Previously we just ran any test project in Compilers.slnf on Unix. That meant though to increase the test projects we run on Unix we need to keep expanding Compilers.slnf which is not what that filter is for. After discussion we've decided to go the following route:

Unix jobs build Roslyn.slnx. This matches our Windows behavior and ensures we keep a clean build experience for our primary solution on both platforms.
Any test project with a simple .NET Core TFM (net9.0, net10.0, etc ...) will run on every platform. If you want a test project to only run on windows then use a platform specific TFM like net10.0-windows.

This job doesn't actually change what tests run on Unix, it's just taking our current state and moving to the new mechanism. A future change will start increasing our Unix test coverage.

After some offline discussion decided to just go ahead and enable test projects that can run on Unix without any changes as part of this PR. Have now done so. The result of the script to decide which did / didn't run without changes is

https://gist.github.com/jaredpar/6fbf7d90e92f9d37a4fdee75a51c75ad

…lection Agent-Logs-Url: https://github.com/dotnet/roslyn/sessions/e4a96939-58da-44e0-8773-df8023435520 Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>

eng/targets/TargetFrameworks.props

src/Tools/PrepareTests/TestDiscovery.cs

src/Tools/Source/RunTests/Program.cs

Agent-Logs-Url: https://github.com/dotnet/roslyn/sessions/b1ff163e-1780-44a0-969f-4bdd88ea82db Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>

…n Compilers.slnf Agent-Logs-Url: https://github.com/dotnet/roslyn/sessions/92a99a58-ee03-4cc9-b98d-b2959e899567 Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>

…ests rehydrate step Agent-Logs-Url: https://github.com/dotnet/roslyn/sessions/ddc03428-c1ba-416d-a46b-080360a74d5d Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>

jaredpar · 2026-03-31T16:53:43Z

@333fred, @dibarbet, @dotnet/roslyn-infrastructure PTAL

RikkiGibson · 2026-03-31T17:02:32Z

Def think it will be good to be able to take this and then perhaps even start enabling tests on a project-by-project basis

jaredpar · 2026-03-31T17:11:24Z

Def think it will be good to be able to take this and then perhaps even start enabling tests on a project-by-project basis

That is my plan. I have follow up PRs that do this. But I wanted to have a single change where keep the tests executed the same, just get us into the new approach

RikkiGibson

Done review pass, I'd like to also compare the PR CI "before-and-after" when it is available

RikkiGibson · 2026-03-31T17:08:36Z

src/Features/TestUtilities/Microsoft.CodeAnalysis.Features.Test.Utilities.csproj

    <OutputType>Library</OutputType>
    <RootNamespace>Microsoft.CodeAnalysis.Test.Utilities</RootNamespace>
-    <TargetFrameworks>$(NetRoslynAll);net472</TargetFrameworks>
+    <TargetFrameworks>$(NetRoslynWindows);net472</TargetFrameworks>


It feels like projects which don't contain tests, such as these .Utilities projects, shouldn't need to move to a windows-specific TFM.

@copilot revert the changes to all the utilities projects.

Reverted all IsTestUtilityProject projects back to their original cross-platform TFMs ($(NetRoslynAll);net472 or $(NetRoslyn)) in 6c9ecac. Test consumers handle platform selection via their own TFMs.

RikkiGibson · 2026-03-31T17:11:59Z

src/Tools/Source/RunTests/Program.cs

+                    return RuntimeInformation.IsOSPlatform(OSPlatform.Windows);
+                }
+
+                if (tfmDirName.EndsWith("-linux", StringComparison.Ordinal))


Is this a real TFM suffix? I didn't find it in https://learn.microsoft.com/en-us/dotnet/standard/frameworks#os-specific-tfms.

That is one I didn't check because I thought for sure -linux was real. I agree it's not in that list but feels odd there is a -android but not -linux. @baronfel?

We don't have a linux-specific surface area/framework, which is what drives the need most of these TFM-based suffixes. The entire feature mostly exists to trigger other extensibility mechanisms like workloads or FrameworkReferences.

@copilot remove the -linux check as it's not a real TFM.

Removed the -linux check in 8851528.

src/Tools/Source/RunTests/Program.cs

333fred

Feels like the blast radius of this is too large. I agree with the principles, but some of these test exclusions seem wrong to me.

eng/targets/TargetFrameworks.props

333fred · 2026-03-31T17:19:46Z

.../Protocol.TestUtilities/Microsoft.CodeAnalysis.LanguageServer.Protocol.Test.Utilities.csproj

    <OutputType>Library</OutputType>
    <RootNamespace>Microsoft.CodeAnalysis.LanguageServer.Protocol.Test.Utilities</RootNamespace>
-    <TargetFrameworks>$(NetRoslynAll);net472</TargetFrameworks>
+    <TargetFrameworks>$(NetRoslynWindows);net472</TargetFrameworks>


Similarly here, thos doesn't seem like it needs to move.

This job is trying to move us to the new way of deciding which tests run without actually changing what is running. This test didn't previously run on Linux hence moved to keep it not running on Linux. My later PR is going to come back and move the ones that can run on Linux over.

At first I tried to do this all in one PR, the review got big, decided to piece meal it.

333fred · 2026-03-31T17:20:35Z

...otocol.Framework.UnitTests/Microsoft.CommonLanguageServerProtocol.Framework.UnitTests.csproj

  <PropertyGroup>
    <StartupObject />
-    <TargetFrameworks>$(NetRoslynAll);net472</TargetFrameworks>
+    <TargetFrameworks>$(NetRoslynWindows);net472</TargetFrameworks>


For these tests (CLASP, LanguageServer, Features tests), do we have a tracking issue for making them run on linux? These are absolutely things that should be testable on linux, since they run on linux.

Ditto for the change of the LanguageServer project itself.

333fred · 2026-03-31T17:21:29Z

...iveAnalyzers/UnitTests/Microsoft.CodeAnalysis.PerformanceSensitiveAnalyzers.UnitTests.csproj

 <Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
-    <TargetFramework>$(NetRoslyn)</TargetFramework>
+    <TargetFramework>$(NetRoslynWindows)</TargetFramework>


What makes this only runnable on Windows?

333fred · 2026-03-31T17:21:41Z

...is.ResxSourceGenerator.UnitTests/Microsoft.CodeAnalysis.ResxSourceGenerator.UnitTests.csproj


  <PropertyGroup>
-    <TargetFramework>$(NetRoslyn)</TargetFramework>
+    <TargetFramework>$(NetRoslynWindows)</TargetFramework>


What makes this only runnable on Windows?

333fred · 2026-03-31T17:21:59Z

...ysis.BannedApiAnalyzers/UnitTests/Microsoft.CodeAnalysis.BannedApiAnalyzers.UnitTests.csproj

 <Project Sdk="Microsoft.NET.Sdk">
  <PropertyGroup>
-    <TargetFramework>$(NetRoslyn)</TargetFramework>
+    <TargetFramework>$(NetRoslynWindows)</TargetFramework>


I'm pretty sure I ran these tests on Linux just a couple weeks ago.

…ject TFMs to cross-platform Agent-Logs-Url: https://github.com/dotnet/roslyn/sessions/66ff5f30-bc9a-474e-aaff-bd0500c36307 Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>

… NetRoslyn Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…NetRoslyn Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…o NetRoslyn Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

jasonmalinowski

Only real concern with this is a lot of tests projects are being marked windows only that I really would expect is already working. Frankly I'd rather review the big PR with a bunch of other changes than this where there's a bunch of head scratching. If it's easy enough to ask Copilot to either either:

Convert projects back where the tests already 100% pass, or
Add a comment to say at least one of the test that are failing and why.

Doesn't have to be a great explanation, but at least there's a bit of a pointer to why it has to stay that way.

jasonmalinowski · 2026-03-31T20:56:40Z

eng/pipelines/test-integration-helix.yml

      # This is a temporary step until the actual test run moves to helix (then we would need to rehydrate the tests there instead)
      - task: BatchScript@1
-        displayName: Rehydrate Microsoft.CodeAnalysis.Workspaces.MSBuild.UnitTests (net10.0)
+        displayName: Rehydrate Microsoft.CodeAnalysis.Workspaces.MSBuild.UnitTests (net10.0-windows)


This should run just fine on Linux/Mac. If this was a change you made just because it's in the Windows queue consider a revert, otherwise add this to your list to invesetigate.

The details for why this fails on Linux are here.

https://gist.github.com/jaredpar/6fbf7d90e92f9d37a4fdee75a51c75ad#microsoftcodeanalysisworkspacesmsbuildunittests

eng/targets/TargetFrameworks.props

jasonmalinowski · 2026-03-31T21:00:45Z

...otocol.Framework.UnitTests/Microsoft.CommonLanguageServerProtocol.Framework.UnitTests.csproj

  <PropertyGroup>
    <StartupObject />
-    <TargetFrameworks>$(NetRoslynAll);net472</TargetFrameworks>
+    <TargetFrameworks>$(NetRoslynWindows);net472</TargetFrameworks>


Ditto for the change of the LanguageServer project itself.

jasonmalinowski · 2026-03-31T21:02:28Z

src/Tools/Source/RunTests/Program.cs

+                    return RuntimeInformation.IsOSPlatform(OSPlatform.Windows);
+                }
+
+                if (tfmDirName.EndsWith("-macos", StringComparison.Ordinal))


Do we have any of these? Or just being complete?

Just being complete.

…NetRoslynWindows to NetRoslyn Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…etRoslynWindows to NetRoslyn Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…slynWindows to NetRoslyn Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…oslyn Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…nWindows to NetRoslyn Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…oslynWindows to NetRoslyn Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

src/Workspaces/Remote/ServiceHubTest/Microsoft.CodeAnalysis.Remote.ServiceHub.UnitTests.csproj

src/Tools/ExternalAccess/RazorTest/Microsoft.CodeAnalysis.ExternalAccess.Razor.UnitTests.csproj

...otocol.Framework.UnitTests/Microsoft.CommonLanguageServerProtocol.Framework.UnitTests.csproj

JoeRobich · 2026-03-31T23:58:29Z

@jaredpar I think you will need this change as well f118c9f for the tests to run in CI

Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>

Switch Unix builds to Roslyn.slnx and use TFM-driven platform test se…

75a6926

…lection Agent-Logs-Url: https://github.com/dotnet/roslyn/sessions/e4a96939-58da-44e0-8773-df8023435520 Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>

Copilot AI assigned Copilot and jaredpar Mar 30, 2026

Copilot created this pull request from a session on behalf of jaredpar March 30, 2026 22:42 View session

jaredpar reviewed Mar 30, 2026

View reviewed changes

eng/targets/TargetFrameworks.props Outdated Show resolved Hide resolved

src/Tools/PrepareTests/TestDiscovery.cs Outdated Show resolved Hide resolved

src/Tools/Source/RunTests/Program.cs Show resolved Hide resolved

Copilot started work on behalf of jaredpar March 30, 2026 22:47 View session

Address review feedback: brace style and NetRoslynWindows TFM value

a58a6e7

Agent-Logs-Url: https://github.com/dotnet/roslyn/sessions/b1ff163e-1780-44a0-969f-4bdd88ea82db Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>

github-actions bot added the Area-Infrastructure label Mar 30, 2026

Copilot finished work on behalf of jaredpar March 30, 2026 22:49

Copilot AI requested a review from jaredpar March 30, 2026 22:49

fix a typo

15510a2

Copilot started work on behalf of jaredpar March 31, 2026 04:28 View session

Add $(NetRoslynWindows) TFM to all test projects in Roslyn.slnx not i…

94c9590

…n Compilers.slnf Agent-Logs-Url: https://github.com/dotnet/roslyn/sessions/92a99a58-ee03-4cc9-b98d-b2959e899567 Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>

Copilot finished work on behalf of jaredpar March 31, 2026 04:36

Copilot started work on behalf of jaredpar March 31, 2026 04:55 View session

Fix test-integration-helix.yml: use net10.0-windows for MSBuild.UnitT…

caa29c4

…ests rehydrate step Agent-Logs-Url: https://github.com/dotnet/roslyn/sessions/ddc03428-c1ba-416d-a46b-080360a74d5d Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>

Copilot finished work on behalf of jaredpar March 31, 2026 04:59

small fix

8b4bc63

jaredpar marked this pull request as ready for review March 31, 2026 16:53

jaredpar requested review from a team as code owners March 31, 2026 16:53

RikkiGibson reviewed Mar 31, 2026

View reviewed changes

Copilot started work on behalf of jaredpar March 31, 2026 17:18 View session

333fred reviewed Mar 31, 2026

View reviewed changes

Address review feedback: remove -osx TFM check and revert utility pro…

6c9ecac

…ject TFMs to cross-platform Agent-Logs-Url: https://github.com/dotnet/roslyn/sessions/66ff5f30-bc9a-474e-aaff-bd0500c36307 Co-authored-by: jaredpar <146967+jaredpar@users.noreply.github.com>

Copilot finished work on behalf of jaredpar March 31, 2026 17:27

Copilot started work on behalf of jaredpar March 31, 2026 17:27 View session

jaredpar and others added 6 commits March 31, 2026 20:40

Port PerformanceSensitiveAnalyzers.UnitTests from NetRoslynWindows to…

3f68551

… NetRoslyn Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Port PublicApiAnalyzers.UnitTests from NetRoslynWindows to NetRoslyn

c09ab3e

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Port Roslyn.Diagnostics.Analyzers.UnitTests from NetRoslynWindows to …

a20a55c

…NetRoslyn Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Port Text.Analyzers.UnitTests from NetRoslynWindows to NetRoslyn

f9d55bd

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Port RulesetToEditorconfigConverter.UnitTests from NetRoslynWindows t…

3a616c1

…o NetRoslyn Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Port Analyzer.Utilities.UnitTests from NetRoslynWindows to NetRoslyn

3d1b211

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

jasonmalinowski approved these changes Mar 31, 2026

View reviewed changes

jaredpar and others added 6 commits March 31, 2026 21:16

Port Microsoft.CommonLanguageServerProtocol.Framework.UnitTests from …

0e9443e

…NetRoslynWindows to NetRoslyn Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Port Microsoft.CodeAnalysis.ExternalAccess.HotReload.UnitTests from N…

cd0454a

…etRoslynWindows to NetRoslyn Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Port Microsoft.CodeAnalysis.ExternalAccess.Razor.UnitTests from NetRo…

769f4b4

…slynWindows to NetRoslyn Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Port SemanticSearch.BuildTask.UnitTests from NetRoslynWindows to NetR…

e193c88

…oslyn Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Port Microsoft.CodeAnalysis.Remote.ServiceHub.UnitTests from NetRosly…

88857c7

…nWindows to NetRoslyn Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Port Microsoft.CodeAnalysis.CSharp.ResultProvider.UnitTests from NetR…

3ffca0c

…oslynWindows to NetRoslyn Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

JoeRobich reviewed Mar 31, 2026

View reviewed changes

src/Workspaces/Remote/ServiceHubTest/Microsoft.CodeAnalysis.Remote.ServiceHub.UnitTests.csproj Outdated Show resolved Hide resolved

JoeRobich reviewed Mar 31, 2026

View reviewed changes

src/Tools/ExternalAccess/RazorTest/Microsoft.CodeAnalysis.ExternalAccess.Razor.UnitTests.csproj Outdated Show resolved Hide resolved

JoeRobich reviewed Mar 31, 2026

View reviewed changes

...otocol.Framework.UnitTests/Microsoft.CommonLanguageServerProtocol.Framework.UnitTests.csproj Outdated Show resolved Hide resolved

respond to PR feedback

98a6690

JoeRobich approved these changes Mar 31, 2026

View reviewed changes

dibarbet approved these changes Apr 1, 2026

View reviewed changes

jaredpar and others added 3 commits March 31, 2026 18:41

Apply suggestions from code review

a07dd02

Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>

Change to a boolean check

c298621

more

1cc26ec

jaredpar requested a review from a team as a code owner April 1, 2026 05:42

jaredpar merged commit f839a71 into main Apr 1, 2026
28 checks passed

jaredpar deleted the copilot/update-unix-testing-logic branch April 1, 2026 07:16

dotnet-policy-service bot added this to the Next milestone Apr 1, 2026

This was referenced Apr 1, 2026

[release/11.0.1xx-preview3] Source code updates from dotnet/roslyn dotnet/dotnet#5828

Merged

[main] Source code updates from dotnet/roslyn dotnet/dotnet#5845

Merged

dotnet-bot mentioned this pull request Apr 8, 2026

[Automated] PRs inserted in VS build main-11707.340 #83096

Closed

Conversation

Copilot AI commented Mar 30, 2026 • edited by jaredpar Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jaredpar commented Mar 31, 2026

Uh oh!

RikkiGibson commented Mar 31, 2026

Uh oh!

jaredpar commented Mar 31, 2026

Uh oh!

RikkiGibson left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

333fred left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jasonmalinowski left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JoeRobich commented Mar 31, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Copilot AI commented Mar 30, 2026 •

edited by jaredpar

Loading

jasonmalinowski left a comment •

edited

Loading