Reduce allocations in TextBufferFactoryCloneService.Clone#82777
Merged
ToddGrun merged 2 commits intoMar 17, 2026
Merged
Conversation
Builds on dotnet#82462 Found another location in roslyn that was potentially creating a text buffer through realization of the full text of a source text. Instead, use the SourceTextReader similar to what was done in the previous PR.
Contributor
Author
|
/pr-val |
Contributor
|
View PR Validation Run triggered by @ToddGrun Parameters
|
Contributor
Author
|
/pr-val |
Contributor
|
View PR Validation Run triggered by @ToddGrun Parameters
|
…ufferCloneService.Clone
Contributor
Author
|
/pr-val |
Contributor
|
View PR Validation Run triggered by @ToddGrun Parameters
|
Contributor
Author
|
@dotnet/roslyn-ide ptal |
This was referenced Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #82462
Found another location in roslyn that was potentially creating a text buffer through realization of the full text of a source text. Instead, use the SourceTextReader similar to what was done in the previous PR. This shows a nice reduction in allocations in the lightbulb speedometer test, particularly LOH allocations.
*** Before ***
*** After ***
Microsoft Reviewers: Open in CodeFlow