Unsafe evolution: add LangVersion error for updated memory safety rules#82687
Merged
Conversation
jcouv
reviewed
Mar 10, 2026
| builder.Add(new CSDiagnostic(new CSDiagnosticInfo(ErrorCode.ERR_CompilationOptionNotAvailable, | ||
| nameof(Options.MemorySafetyRules), Options.MemorySafetyRules, LanguageVersion.ToDisplayString(), | ||
| new CSharpRequiredLanguageVersion(MessageID.IDS_FeatureUnsafeEvolution.RequiredVersion())), Location.None)); | ||
| } |
Member
There was a problem hiding this comment.
Not sure why, but this file made CodeFlow pretty unhappy for me. Is it the same for you?
Member
Author
There was a problem hiding this comment.
It took long time (like a minute) to load, but eventually loaded fine.
Member
Author
|
@333fred for another review, thanks |
333fred
approved these changes
Mar 11, 2026
This was referenced Mar 12, 2026
This was referenced Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan: #81207
Should resolve "MemorySafetyRulesAttribute / LangVer" item from the test plan.
Microsoft Reviewers: Open in CodeFlow