Unsafe evolution: add more tests#82683
Conversation
| options: TestOptions.UnsafeReleaseExe.WithUpdatedMemorySafetyRules(), | ||
| expectedOutput: "System.Action") | ||
| .VerifyDiagnostics(); | ||
| } |
There was a problem hiding this comment.
Another language question: what should we do about expression trees? (added a bullet to test plan) #Closed
There was a problem hiding this comment.
I don't think we need to do anything? Adding a test for how it works today.
| } | ||
|
|
||
| [Fact] | ||
| public void Member_Method_ConvertToDelegate_Inferred() |
There was a problem hiding this comment.
nit: For this test, consider adding an invocation of the various local variables outside of unsafe context #Closed
There was a problem hiding this comment.
Extended this test, let me know if that's not what you had in mind.
| options: TestOptions.UnsafeReleaseExe.WithUpdatedMemorySafetyRules(), | ||
| expectedOutput: "System.Action") | ||
| .VerifyDiagnostics(); | ||
| } |
There was a problem hiding this comment.
Regarding "LangVer tests should include C#Next": Member_LangVersion should probably check RegularNext too.
Extern_ and CompatMode_ tests are probably fine, since they are intentionally targeting older LangVer only. But worth confirming #Closed
There was a problem hiding this comment.
I will add RegularNext to the tests where it's missing, thanks.
Test plan: #81207
These unchecked items from the test plan should be handled (either by this PR or already previously):