Ensure that a double-dispose of CPSProject doesn't throw#82557
Merged
Conversation
JoeRobich
approved these changes
Feb 26, 2026
JoeRobich
left a comment
Member
There was a problem hiding this comment.
Do we want to track double disposal?
drewnoakes
approved these changes
Feb 27, 2026
Member
Author
It sounds like changes on the project system side now mean they expect us to follow the "official" IDisposable rules of double dispose being safe. So this is just making that follow the real contract, and doesn't really indicate a problem now. |
ToddGrun
approved these changes
Feb 27, 2026
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.