Skip to content

Fix binding of nameof of Color Color#82477

Merged
jjonescz merged 5 commits into
dotnet:mainfrom
jjonescz:82474-NameOf-ColorColor
Feb 26, 2026
Merged

Fix binding of nameof of Color Color#82477
jjonescz merged 5 commits into
dotnet:mainfrom
jjonescz:82474-NameOf-ColorColor

Conversation

@jjonescz

@jjonescz jjonescz commented Feb 20, 2026

Copy link
Copy Markdown
Member

Fixes #82474.

@jjonescz jjonescz requested a review from AlekseyTs February 20, 2026 13:37
AlekseyTs
AlekseyTs reviewed Feb 20, 2026
View reviewed changes
Comment thread src/Compilers/CSharp/Portable/Binder/Binder_Invocation.cs Outdated
@AlekseyTs

AlekseyTs commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Done with review pass (commit 1) #Closed

AlekseyTs
AlekseyTs reviewed Feb 20, 2026
View reviewed changes
Comment thread src/Compilers/CSharp/Portable/Binder/Binder_Invocation.cs Outdated
@jjonescz jjonescz marked this pull request as ready for review February 20, 2026 15:50
@jjonescz jjonescz requested a review from a team as a code owner February 20, 2026 15:50
AlekseyTs
AlekseyTs reviewed Feb 20, 2026
View reviewed changes
Comment thread src/Compilers/CSharp/Test/Semantic/Semantics/NameOfTests.cs Outdated
AlekseyTs
AlekseyTs reviewed Feb 20, 2026
View reviewed changes
Comment thread src/Compilers/CSharp/Portable/Binder/Binder_Invocation.cs Outdated
AlekseyTs
AlekseyTs reviewed Feb 20, 2026
View reviewed changes
Comment thread src/Compilers/CSharp/Portable/Binder/Binder_Invocation.cs Outdated
@AlekseyTs

AlekseyTs commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Done with review pass (commit 1) #Closed

@jjonescz jjonescz requested a review from AlekseyTs February 23, 2026 09:34
AlekseyTs
AlekseyTs reviewed Feb 23, 2026
View reviewed changes
Comment thread src/Compilers/CSharp/Portable/Binder/Binder_Expressions.cs Outdated
@AlekseyTs

AlekseyTs commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

Done with review pass (commit 4)

@jjonescz jjonescz requested a review from AlekseyTs February 23, 2026 16:43
AlekseyTs
AlekseyTs approved these changes Feb 23, 2026
View reviewed changes

@AlekseyTs AlekseyTs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 5)

@jjonescz jjonescz requested a review from a team February 23, 2026 20:31
@jjonescz

jjonescz commented Feb 25, 2026

Copy link
Copy Markdown
Member Author

@dotnet/roslyn-compiler for another review, thanks

@jjonescz jjonescz merged commit 662dc29 into dotnet:main Feb 26, 2026
24 checks passed
@jjonescz jjonescz deleted the 82474-NameOf-ColorColor branch February 26, 2026 10:30
@dotnet-policy-service dotnet-policy-service Bot added this to the Next milestone Feb 26, 2026
This was referenced Feb 27, 2026
Merged
Merged
@dotnet-bot dotnet-bot mentioned this pull request Mar 3, 2026
Closed
@dotnet-maestro dotnet-maestro Bot mentioned this pull request Mar 5, 2026
Merged
@dotnet-bot dotnet-bot mentioned this pull request Mar 14, 2026
Closed
@jjonescz jjonescz modified the milestones: Next, 18.6 Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@333fred 333fred 333fred approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

Assignees

No one assigned

Labels

Area-Compilers

Projects

None yet

Milestone

18.6

Development

Successfully merging this pull request may close these issues.

nameof of Color Color in field initializer results in "Unable to determine specific cause of the failure."

3 participants

@jjonescz @AlekseyTs @333fred