Run the Linux Single Machine CI with the Spanish locale.#82450
Merged
Conversation
Moves the Windows Spanish CI leg to run on rolling builds.
This comment was marked as resolved.
This comment was marked as resolved.
c16ea18 to
657872b
Compare
JoeRobich
commented
Feb 23, 2026
| diff1.EmitResult.Diagnostics.Verify( | ||
| // error CS7043: Cannot emit update; constructor 'System.Exception..ctor(string)' is missing. | ||
| Diagnostic(ErrorCode.ERR_EncUpdateFailedMissingSymbol).WithArguments("constructor", "System.Exception..ctor(string)").WithLocation(1, 1), | ||
| Diagnostic(ErrorCode.ERR_EncUpdateFailedMissingSymbol).WithArguments(CodeAnalysisResources.Constructor, "System.Exception..ctor(string)").WithLocation(1, 1), |
Member
Author
There was a problem hiding this comment.
CodeAnalysisResources was used elsewhere in this test file but not in these tests. This showed up in failures similar to expected: "method" and actual: "método". #Closed
Contributor
There was a problem hiding this comment.
I think this indicates a real product issue. When diagnostic is created, its arguments should not be pulled from resources by using default culture.
Contributor
There was a problem hiding this comment.
LocalizableErrorArgument or something similar should be used instead.
JoeRobich
commented
Feb 23, 2026
|
|
||
| var cmd = CreateCSharpCompiler(null, dir.Path, | ||
| new[] { "/t:library", "/nologo", "/warnaserror+", src.Path }, | ||
| new[] { "/t:library", "/preferreduilang:en", "/nologo", "/warnaserror+", src.Path }, |
Member
Author
There was a problem hiding this comment.
Other tests were already setting /preferreduilang:en prior to checking error string.
JoeRobich
commented
Feb 24, 2026
AlekseyTs
reviewed
Feb 24, 2026
AlekseyTs
reviewed
Feb 24, 2026
AlekseyTs
reviewed
Feb 24, 2026
AlekseyTs
reviewed
Feb 24, 2026
AlekseyTs
reviewed
Feb 24, 2026
Contributor
|
Done with review pass (commit 6) #Closed |
Member
Author
|
@AlekseyTs Ready for another review. |
Contributor
|
Done with review pass (commit 7) |
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have a Linux leg running in helix. The single machine run of Linux is just to ensure we haven't broken the test runner's ability to run tests locally. This repurposes it for the Spanish locale tests that run for each PR.
Also, moves the Windows Spanish CI leg to run on rolling builds.