Remove error reporting out of clasp and rely on host to report errors#82435
Merged
Conversation
dibarbet
commented
Feb 17, 2026
| var exceptionToReport = TryGetReportableException(e); | ||
| if (exceptionToReport != null) | ||
| { | ||
| FatalError.ReportNonFatalError(exceptionToReport, ErrorSeverity.Critical); |
Member
Author
There was a problem hiding this comment.
exception flows through to callers of WaitForExitAsync, and they handle it as needed
dibarbet
commented
Feb 17, 2026
| if (_shutdownRequestTask == null) | ||
| { | ||
| throw new InvalidOperationException("The language server has not yet been asked to shutdown."); | ||
| throw new ServerNotShutDownException("The language server has not yet been asked to shutdown."); |
Member
Author
There was a problem hiding this comment.
to allow callers to distinguish between an error calling waitforexitasync, and the error that caused the languageserver to shutdown.
davidwengier
approved these changes
Feb 17, 2026
JoeRobich
approved these changes
Feb 17, 2026
This was referenced Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue found by @davidwengier where we can't use FatalError in clasp (used by Razor/Webtools who do not have that type).
Also fixes issue where if the server encountered a queue error in VS, it could not be restarted as restart would throw.