Skip to content

Hot Reload External Access: Add API for updating multiple projects#82240

Merged
tmat merged 2 commits into
dotnet:mainfrom
tmat:UpdateGraph
Feb 5, 2026
Merged

Hot Reload External Access: Add API for updating multiple projects#82240
tmat merged 2 commits into
dotnet:mainfrom
tmat:UpdateGraph

Conversation

@tmat

@tmat tmat commented Jan 31, 2026

Copy link
Copy Markdown
Member

No description provided.

@tmat tmat requested a review from a team as a code owner January 31, 2026 18:04
@tmat tmat changed the title Add API for updating multiple projects Hot Reload External Access: Add API for updating multiple projects Jan 31, 2026
@tmat

tmat commented Jan 31, 2026

Copy link
Copy Markdown
Member Author

@DustinCampbell ptal

Comment thread src/Workspaces/MSBuild/Core/Microsoft.CodeAnalysis.Workspaces.MSBuild.csproj Outdated

@DustinCampbell DustinCampbell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change looks fine. I'll defer to @jasonmalinowski for the package dependency change.

@jasonmalinowski jasonmalinowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change for the NuGet reference will break our customers since we tell them not to use MSBuildLocator anymore. If the problem is this is causing issues for dotnet watch (which I can totally understand) then we'll need an alternate approach. MSBuildLocator's NuGet package itself already has special logic to block other packages, so maybe we can reuse that if needed.

Comment thread src/Workspaces/MSBuild/Core/Microsoft.CodeAnalysis.Workspaces.MSBuild.csproj Outdated
@tmat

tmat commented Feb 4, 2026

Copy link
Copy Markdown
Member Author

Is hot reload only referencing our ExternalAPIs or also referencing this assembly too?

Only ExternalAccess layer.

@tmat

tmat commented Feb 4, 2026

Copy link
Copy Markdown
Member Author

Removed the package ref changes.

@jasonmalinowski jasonmalinowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We found a different solution for the other problem, so approved.

@tmat tmat enabled auto-merge (squash) February 4, 2026 17:09
@tmat tmat merged commit 5f03d61 into dotnet:main Feb 5, 2026
24 of 25 checks passed
@dotnet-policy-service dotnet-policy-service Bot added this to the Next milestone Feb 5, 2026
@tmat tmat deleted the UpdateGraph branch February 5, 2026 21:24
@akhera99 akhera99 modified the milestones: Next, 18.5 Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants