Unions: Avoid invalid cast exception in erroneous code#82213
Merged
Conversation
RikkiGibson
approved these changes
Jan 29, 2026
Contributor
Author
|
@333fred, @dotnet/roslyn-compiler For a second review |
jcouv
approved these changes
Jan 29, 2026
jcouv
left a comment
Member
There was a problem hiding this comment.
LGTM Thanks (commit 1). Consider adding the repro test as well
Contributor
Author
Not in this PR. The change is strait forward. This change is another one that must be shared with closed classes, and having a union test in the same commit might make the sharing more complicated. |
This was referenced Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.