Fix detection of embedded c# code#82033
Merged
Merged
Conversation
CyrusNajmabadi
commented
Jan 15, 2026
| { | ||
| var namePortion = string.Join("|", identifiers.Select(n => $"({Regex.Escape(n)})")); | ||
| _regex = new Regex($@"^((//)|(')|(/\*))\s*lang(uage)?\s*=\s*(?<identifier>{namePortion})\b((\s*,\s*)(?<option>[a-zA-Z]+))*", | ||
| _regex = new Regex($@"^((//)|(')|(/\*))\s*lang(uage)?\s*=\s*(?<identifier>{namePortion})(?!\w)((\s*,\s*)(?<option>[a-z]+))*", |
Contributor
Author
There was a problem hiding this comment.
from Stephen. ?!\w is a better choice saying no match if we are immedaitely followed by a letter. (we don't want Routebad to match Route. And we don't need A-Z because we're already passing IgnoreCase below.
Contributor
Author
|
@JoeRobich ptal. :) |
JoeRobich
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
// lang=c#wasn't working as the regex we had didn't like a#at the end.Looks like this: