Create Red-Green Trees.md#82025
Merged
Merged
Conversation
jjonescz
approved these changes
Jan 15, 2026
Contributor
Author
|
Going to wait to let Fred and Joseph also take a pass. |
Added details about weakly-held red children optimization and its current usage in Roslyn.
CyrusNajmabadi
commented
Jan 15, 2026
333fred
reviewed
Jan 15, 2026
| parameter list isn't just theoretically shareable—it's *actually* shared because the cache returns | ||
| the same node every time that construct is parsed. | ||
|
|
||
| ## Token Storage Optimizations |
Member
There was a problem hiding this comment.
Don't we cache some types of trivia text? Like single spaces, newlines, and such?
jnm2
approved these changes
Jan 15, 2026
Co-authored-by: Fred Silberberg <frsilb@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.