SwitchBinder.KeyForConstant: nint/nuint values should not collide with values for constants of other types.#81794
Merged
Merged
Conversation
…h values for constants of other types. Fixes dotnet#81784
Contributor
Author
|
@dotnet/roslyn-compiler Please review |
333fred
reviewed
Dec 24, 2025
Contributor
Author
|
@dotnet/roslyn-compiler Please review |
1 similar comment
Contributor
Author
|
@dotnet/roslyn-compiler Please review |
333fred
approved these changes
Dec 29, 2025
Contributor
Author
|
@dotnet/roslyn-compiler For a second review |
1 similar comment
Contributor
Author
|
@dotnet/roslyn-compiler For a second review |
| return; | ||
| } | ||
|
|
||
| var source = $$$""" |
Contributor
There was a problem hiding this comment.
nit: only two dollars seem needed here.
CyrusNajmabadi
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #81784