Extensions: fix RemoveUnusedMember scenarios#81754
Merged
Merged
Conversation
Comment on lines
+279
to
+281
| { | ||
| symbolStartContext.RegisterSymbolEndAction(symbolEndContext => OnSymbolEnd(symbolEndContext, hasUnsupportedOperation)); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| { | |
| symbolStartContext.RegisterSymbolEndAction(symbolEndContext => OnSymbolEnd(symbolEndContext, hasUnsupportedOperation)); | |
| } | |
| symbolStartContext.RegisterSymbolEndAction(symbolEndContext => OnSymbolEnd(symbolEndContext, hasUnsupportedOperation)); | |
| ``` #ByDesign |
Member
Author
There was a problem hiding this comment.
I kept those braces as neither the condition nor the branch are simple, so find this this easier to read
Comment on lines
+290
to
+292
| { | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| { | |
| return false; | |
| } | |
| return false; |
Also, consider a comment above the if. but ok if not present. #Resolved
Comment on lines
+746
to
+748
| { | ||
| yield return extensionMember; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| { | |
| yield return extensionMember; | |
| } | |
| yield return extensionMember; | |
| ``` #Resolved |
Comment on lines
+830
to
+833
| if (extensionBlockMethod.AssociatedSymbol is { } associatedSymbol) | ||
| { | ||
| AddIfCandidateSymbol(builder, associatedSymbol); | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| if (extensionBlockMethod.AssociatedSymbol is { } associatedSymbol) | |
| { | |
| AddIfCandidateSymbol(builder, associatedSymbol); | |
| } | |
| AddIfCandidateSymbol(builder, extensionBlockMethod.AssociatedSymbol); | |
| ``` #Resolved |
Comment on lines
+39
to
+42
| foreach (var extensionMember in extensionBlock.Members) | ||
| { | ||
| yield return extensionMember; | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| foreach (var extensionMember in extensionBlock.Members) | |
| { | |
| yield return extensionMember; | |
| } | |
| foreach (var extensionMember in extensionBlock.Members) | |
| yield return extensionMember; | |
| ``` #Resolved |
| FixedCode = code, | ||
| LanguageVersion = LanguageVersion.CSharp14, | ||
| }.RunAsync(); | ||
| } |
Contributor
There was a problem hiding this comment.
you can just inline 'code' and remove the 'fixedcode=code' line in all of these. then make the methods not async/awit. but instead just return the new Test { ... }.RunAsync(); #Resolved
Comment on lines
+37
to
+38
| if (associated is null) | ||
| continue; |
Contributor
There was a problem hiding this comment.
Suggested change
| if (associated is null) | |
| continue; | |
| ``` #Resolved |
Member
Author
There was a problem hiding this comment.
Sorry, I'd misunderstood the suggestion in previous PR because of how the diff is shown in CodeFlow...
CyrusNajmabadi
approved these changes
Dec 18, 2025
This was referenced Dec 20, 2025
This was referenced Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #80645 and related issues #81213 and #81657
The principle of
AbstractRemoveUnusedMembersDiagnosticAnalyzeris that we respond to member declarations by registering them (AnalyzeSymbolDeclaration), then analyze various references (invocations, member references, deconstructions, nameof, cref, etc), then when we exit the type we can report private unused members.The change is that we treat extension members as part of the enclosing static class:
Additionally, any usage of disambiguation syntax marks the corresponding extension member as "used".