Handle potential null in extension lookup (#80621)#81740
Merged
333fred merged 1 commit intodotnet:release/dev18.0from Dec 22, 2025
Merged
Handle potential null in extension lookup (#80621)#81740333fred merged 1 commit intodotnet:release/dev18.0from
333fred merged 1 commit intodotnet:release/dev18.0from
Conversation
There are specific scenarios where applicability will remove a symbol from lookup entirely; no error, just silent removal. This introduces a `null` that consumers were not expecting and caused an NRE. I've handled that NRE here and annotated the API. Fixes https://developercommunity.visualstudio.com/t/NRE-in-Roslyn-v500-225451107/10979295. (cherry picked from commit 16883a5)
jjonescz
approved these changes
Dec 18, 2025
CyrusNajmabadi
approved these changes
Dec 18, 2025
Member
Author
|
Approved by tactics on 12/20/25. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are specific scenarios where applicability will remove a symbol from lookup entirely; no error, just silent removal. This introduces a
nullthat consumers were not expecting and caused an NRE. I've handled that NRE here and annotated the API. Fixes https://developercommunity.visualstudio.com/t/NRE-in-Roslyn-v500-225451107/10979295.(cherry picked from commit 16883a5)