Restore parsing from old branch#81705
Merged
333fred merged 4 commits intodotnet:features/dictionary-expressionsfrom Jan 5, 2026
Merged
Restore parsing from old branch#81705333fred merged 4 commits intodotnet:features/dictionary-expressionsfrom
333fred merged 4 commits intodotnet:features/dictionary-expressionsfrom
Conversation
Restore the parsing from the previous dictionary expressions branch and update tests. Binding is not yet restored.
Contributor
|
I will look tomorrow. Pretty sure I wrote it. But it will be good to do a once over again. |
Member
Author
|
@CyrusNajmabadi @jcouv for reviews. |
| analyzer.VerifyAnalyzeSymbolCalledForAllSymbolKinds(); | ||
| analyzer.VerifyAnalyzeNodeCalledForAllSyntaxKinds([]); | ||
| // PROTOTYPE: Add to all-in-one | ||
| analyzer.VerifyAnalyzeNodeCalledForAllSyntaxKinds([SyntaxKind.KeyValuePairElement]); |
Contributor
There was a problem hiding this comment.
note: i've found it easier to jsut add to all-in-one. there's already a collection section at the bottom of the file. #ByDesign
Member
Author
There was a problem hiding this comment.
There's no binding behavior, so I don't want to deal with that yet.
CyrusNajmabadi
approved these changes
Dec 16, 2025
8 tasks
jcouv
reviewed
Jan 5, 2026
src/Compilers/CSharp/Test/Syntax/Parsing/CollectionExpressionParsingTests.cs
Show resolved
Hide resolved
| var colonToken = this.TryEatToken(SyntaxKind.ColonToken); | ||
| return colonToken != null | ||
| ? _syntaxFactory.KeyValuePairElement(expression, colonToken, this.ParseExpressionCore()) | ||
| : _syntaxFactory.ExpressionElement(expression); |
Contributor
There was a problem hiding this comment.
Entirely up to you. But verbiage was added to the spec stating that we take a lexical prefix oriented view around parsing. We could link to that, or include that text here. Or, if you think it's not necessary, that's also fine.
Contributor
|
LGTM. |
4082a58
into
dotnet:features/dictionary-expressions
28 of 29 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore the parsing from the previous dictionary expressions branch and update tests. Binding is not yet restored.
Relates to test plan #81860