Skip to content

Add empty CSharp15 test project#81512

Merged
jcouv merged 6 commits intodotnet:mainfrom
jcouv:emit-15
Dec 3, 2025
Merged

Add empty CSharp15 test project#81512
jcouv merged 6 commits intodotnet:mainfrom
jcouv:emit-15

Conversation

@jcouv
Copy link
Member

@jcouv jcouv commented Dec 2, 2025 •
edited
Loading

Instead of pilling on more tests into Emit3, we can create a project per release. That way we won't run into string limits and we'll hopefully reduce test discovery time.

@jcouv jcouv changed the title Add empty Emit15 test project Add empty Test15 test project Dec 2, 2025
@jcouv jcouv marked this pull request as ready for review December 2, 2025 20:29
@jcouv jcouv requested review from a team as code owners December 2, 2025 20:29
@jcouv jcouv changed the title Add empty Test15 test project Add empty CSharp15 test project Dec 3, 2025
@jcouv jcouv requested review from 333fred and jjonescz December 3, 2025 00:02
333fred
333fred reviewed Dec 3, 2025
View reviewed changes
333fred
333fred approved these changes Dec 3, 2025
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like @dibarbet to double check to make sure that we're not missing anything for helix or the like.

@jcouv jcouv requested a review from dibarbet December 3, 2025 03:37
@AlekseyTs
Copy link
Contributor

AlekseyTs commented Dec 3, 2025

It would be good to confirm that added tests will be actually executed locally (from VS, from command line: build -testCoreClr -testCompilerOnly, build -testDesktop -testCompilerOnly, etc.) and will be executed by CI.

@jcouv
Copy link
Member Author

jcouv commented Dec 3, 2025

It would be good to confirm that added tests will be actually executed locally (from VS, from command line: build -testCoreClr -testCompilerOnly, build -testDesktop -testCompilerOnly, etc.) and will be executed by CI.

An earlier commit added a dummy test and I verified that it failed as expected and got caught by CI as well. I also verified that I could run the test from VS locally.

@jcouv jcouv merged commit f445b97 into dotnet:main Dec 3, 2025
29 checks passed
@jcouv jcouv deleted the emit-15 branch December 3, 2025 20:05
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Dec 3, 2025
@dotnet-maestro dotnet-maestro bot mentioned this pull request Dec 4, 2025
Merged
This was referenced Dec 5, 2025
Closed
Closed
@dotnet-maestro dotnet-maestro bot mentioned this pull request Dec 18, 2025
Merged
@davidwengier davidwengier modified the milestones: Next, 18.3 Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@333fred 333fred 333fred approved these changes

@jjonescz jjonescz jjonescz approved these changes

@dibarbet dibarbet dibarbet approved these changes

@AlekseyTs AlekseyTs AlekseyTs approved these changes

Assignees

No one assigned

Labels

Area-Infrastructure

Projects

None yet

Milestone

18.3

Development

Successfully merging this pull request may close these issues.

6 participants

@jcouv @AlekseyTs @333fred @jjonescz @dibarbet @davidwengier