Fix IDE0048 to trigger consistently for is null and is not null in coalesce expressions#81489
Merged
CyrusNajmabadi merged 5 commits intomainfrom Dec 1, 2025
Merged
Conversation
…ce expressions Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix IDE0048 issue for is not null in expressions
Fix IDE0048 to trigger consistently for Nov 30, 2025
is null and is not null in coalesce expressions
src/Analyzers/CSharp/Tests/AddRequiredParentheses/AddRequiredExpressionParenthesesTests.cs
Outdated
Show resolved
Hide resolved
src/Analyzers/CSharp/Tests/AddRequiredParentheses/AddRequiredExpressionParenthesesTests.cs
Outdated
Show resolved
Hide resolved
akhera99
approved these changes
Dec 1, 2025
This was referenced Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IDE0048 triggers for
left?.Equals(right) ?? right is nullbut not forleft?.Equals(right) ?? right is not null.Changes
IsBinaryLike: Added pattern match forIsPatternExpressionSyntax { Pattern: UnaryPatternSyntax { Pattern: ConstantPatternSyntax } }to recognizeis not nullGetPartsOfBinaryLike: Added corresponding case to extract parts from theis not nullpatternTryGetAppropriateParent: Updated to navigate throughUnaryPatternSyntaxwhen the constant pattern is wrapped bynotThe root cause was that
is nullproducesConstantPatternSyntaxdirectly, whileis not nullwraps it in aUnaryPatternSyntax.Fixes #81488
Original prompt
is nullbut not foris not nullin null-coalescing expressions #81488💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.