Skip to content

Unsafe evolution: add MemorySafetyRules attribute#81441

Merged
jjonescz merged 13 commits into
dotnet:features/UnsafeEvolutionfrom
jjonescz:Unsafe-03-RulesAttribute
Dec 8, 2025
Merged

Unsafe evolution: add MemorySafetyRules attribute#81441
jjonescz merged 13 commits into
dotnet:features/UnsafeEvolutionfrom
jjonescz:Unsafe-03-RulesAttribute

Conversation

@jjonescz

@jjonescz jjonescz commented Nov 25, 2025

Copy link
Copy Markdown
Member

Test plan: #81207

Inspired by RefSafetyRules attribute.

Relevant speclet section: https://github.com/dotnet/csharplang/blob/main/proposals/unsafe-evolution.md#metadata

@jjonescz
Add MemorySafetyRules attribute
b47712f 
Inspired by RefSafetyRules attribute.
@jjonescz jjonescz marked this pull request as ready for review November 25, 2025 17:36
@jjonescz jjonescz requested a review from a team as a code owner November 25, 2025 17:36
@jjonescz jjonescz requested review from 333fred and jcouv November 25, 2025 17:36
@jcouv jcouv self-assigned this Nov 25, 2025
@jjonescz

jjonescz commented Dec 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

@333fred @jcouv for reviews, thanks #Closed

1 similar comment
@jjonescz

jjonescz commented Dec 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

@333fred @jcouv for reviews, thanks #Closed

333fred
333fred reviewed Dec 2, 2025
View reviewed changes

@333fred 333fred left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't fully review the tests, too many questions on the first couple for me to continue.

Comment thread ...s/CSharp/Portable/Symbols/Synthesized/SynthesizedEmbeddedMemorySafetyRulesAttributeSymbol.cs
Comment thread src/Compilers/CSharp/Test/Emit3/Semantics/UnsafeEvolutionTests.cs Outdated
Comment thread src/Compilers/CSharp/Test/Emit3/Semantics/UnsafeEvolutionTests.cs Outdated
Comment thread src/Compilers/CSharp/Test/Emit3/Semantics/UnsafeEvolutionTests.cs Outdated
Comment thread src/Compilers/CSharp/Test/Emit3/Semantics/UnsafeEvolutionTests.cs Outdated
Comment thread src/Compilers/CSharp/Test/Emit3/Semantics/UnsafeEvolutionTests.cs Outdated
@jjonescz jjonescz requested a review from 333fred December 3, 2025 12:29
333fred
333fred reviewed Dec 3, 2025
View reviewed changes
Comment thread src/Compilers/CSharp/Test/Emit3/Semantics/UnsafeEvolutionTests.cs
jcouv
jcouv reviewed Dec 3, 2025
View reviewed changes
Comment thread src/Compilers/CSharp/Portable/CSharpCompilationOptions.cs
jcouv
jcouv reviewed Dec 3, 2025
View reviewed changes
Comment thread src/Compilers/CSharp/Portable/Symbols/Metadata/PE/PEModuleSymbol.cs Outdated
jcouv
jcouv reviewed Dec 3, 2025
View reviewed changes
Comment thread src/Compilers/CSharp/Portable/Symbols/Metadata/PE/PEModuleSymbol.cs
jcouv
jcouv reviewed Dec 3, 2025
View reviewed changes
Comment thread src/Compilers/CSharp/Portable/Symbols/Metadata/PE/PEMethodSymbol.cs
jcouv
jcouv reviewed Dec 3, 2025
View reviewed changes
Comment thread src/Compilers/CSharp/Portable/Symbols/Source/SourceModuleSymbol.cs Outdated
jcouv
jcouv reviewed Dec 3, 2025
View reviewed changes
Comment thread src/Compilers/CSharp/Test/Emit3/Semantics/UnsafeEvolutionTests.cs Outdated
jcouv
jcouv reviewed Dec 3, 2025
View reviewed changes
Comment thread src/Compilers/CSharp/Test/Emit3/Semantics/UnsafeEvolutionTests.cs Outdated
jcouv
jcouv reviewed Dec 3, 2025
View reviewed changes
Comment thread src/Compilers/Core/Portable/MetadataReader/PEModule.cs
jcouv
jcouv reviewed Dec 3, 2025
View reviewed changes

@jcouv jcouv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with review pass (commit 6)

@jjonescz jjonescz requested review from 333fred and jcouv December 4, 2025 12:58
jcouv
jcouv approved these changes Dec 4, 2025
View reviewed changes

@jcouv jcouv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (commit 10) with minor feedback on LINQ usage

@jjonescz

jjonescz commented Dec 5, 2025

Copy link
Copy Markdown
Member Author

@333fred for another look, thanks

jcouv
jcouv approved these changes Dec 8, 2025
View reviewed changes

@jcouv jcouv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (commit 13)

@jjonescz jjonescz merged commit 2bbe96e into dotnet:features/UnsafeEvolution Dec 8, 2025
29 checks passed
@jjonescz jjonescz deleted the Unsafe-03-RulesAttribute branch December 8, 2025 08:48
This was referenced Feb 27, 2026
Merged
Merged
@dotnet-bot dotnet-bot mentioned this pull request Mar 3, 2026
Closed
@dotnet-maestro dotnet-maestro Bot mentioned this pull request Mar 5, 2026
Merged
@dotnet-bot dotnet-bot mentioned this pull request Mar 14, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@333fred 333fred 333fred approved these changes

@jcouv jcouv jcouv approved these changes

Assignees

@jcouv jcouv

Labels

Area-Compilers Feature - Unsafe Evolution

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jjonescz @333fred @jcouv