Skip to content

Fix CS0419 to display fully qualified type names for ambiguous cref symbols#81148

Merged
CyrusNajmabadi merged 10 commits intomainfrom
copilot/fix-ambiguous-reference-cs0419
Nov 11, 2025
Merged

Fix CS0419 to display fully qualified type names for ambiguous cref symbols#81148
CyrusNajmabadi merged 10 commits intomainfrom
copilot/fix-ambiguous-reference-cs0419

Conversation

Copy link
Contributor

Copilot AI commented Nov 10, 2025 •
edited
Loading

Plan for fixing CS0419 to include fully qualified references

  • Understand the issue: CS0419 warning message should show fully qualified names like CS0104 does
  • Locate the code that generates the warning in Binder_Crefs.cs
  • Identify that CS0104 uses SymbolDisplayFormat.CSharpErrorMessageFormat for displaying symbols
  • Create a test case that reproduces the issue from the problem statement
  • Modify the code to use FormattedSymbol with CSharpErrorMessageFormat in both locations
  • Add test for the new behavior with types in different namespaces
  • Build and test the changes - all tests pass (225 CrefTests, all CS0419 tests pass)
  • Run code review and security checks - no issues found
  • Fix WorkItem attribute to reference correct issue Include fully qualified references in CS0419 to make it less confusing #4031
  • Make test classes non-public to simplify test expectations
  • Add test for ambiguous method references with parameters (covers PerformCrefOverloadResolution path)

Summary

Successfully fixed CS0419 to display fully qualified type names in ambiguous reference warnings, matching the behavior of CS0104. The warning message now clearly shows the namespace qualification of ambiguous types and methods, making it obvious where the conflicts are coming from.

Changes Made

  1. Binder_Crefs.cs: Modified two locations where WRN_AmbiguousXMLReference is generated:

    • Line 911: ProcessParameterlessCrefMemberLookupResults - tested by AmbiguousReferenceInDifferentNamespaces
    • Line 1069: PerformCrefOverloadResolution - tested by AmbiguousReferenceInDifferentNamespaces_WithParameters
    • Both now wrap symbols with FormattedSymbol using SymbolDisplayFormat.CSharpErrorMessageFormat

  2. CrefTests.cs: Added test cases that verify the new behavior:

Example

Before:

CS0419  Ambiguous reference in cref attribute: 'TypeA'. Assuming 'TypeA', but could have also matched other overloads including 'TypeA'.

After:

CS0419  Ambiguous reference in cref attribute: 'TypeA'. Assuming 'System.Goo.TypeA', but could have also matched other overloads including 'System.TypeA'.
Original prompt

This section details on the original issue you should resolve

<issue_title>Include fully qualified references in CS0419 to make it less confusing</issue_title>
<issue_description>Given the following:

namespace System
{
    public class TypeA
    {
    }
}

namespace System.Foo
{
    public class TypeA
    {
    }
}

namespace A
{
    using System;
    using System.Foo;

    /// <summary>
    ///     <see cref="TypeA"/>
    /// </summary>
    public class Bar
    {
    }
}

You get the following:

CS0419  Ambiguous reference in cref attribute: 'TypeA'. Assuming 'TypeA', but could have also matched other overloads including 'TypeA'.

This is confusing, it should fully qualify the type to make it obvious where the two references are coming from, similar to CS0104:

CS0104  'TypeA' is an ambiguous reference between 'System.Foo.TypeA' and 'System.TypeA'

</issue_description>

Comments on the Issue (you are @copilot in this section)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@CyrusNajmabadi
Fix CS0419 to include fully qualified type names in ambiguous referen…
bcadeab 
…ce warnings

Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Copilot AI changed the title [WIP] Include fully qualified references in CS0419 error Fix CS0419 to display fully qualified type names for ambiguous cref symbols Nov 10, 2025
Copilot AI requested a review from CyrusNajmabadi November 10, 2025 23:51
CyrusNajmabadi
CyrusNajmabadi reviewed Nov 10, 2025
View reviewed changes
src/Compilers/CSharp/Test/Symbol/DocumentationComments/CrefTests.cs Outdated
Assert.Equal(SymbolKind.Property, symbol.Kind);
}

[Fact, WorkItem("https://github.com/dotnet/roslyn/issues/12345")]
Copy link
Contributor

@CyrusNajmabadi CyrusNajmabadi Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot should be #4031

Copy link
Contributor Author

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in eaef250

CyrusNajmabadi
CyrusNajmabadi reviewed Nov 11, 2025
View reviewed changes
src/Compilers/CSharp/Test/Symbol/DocumentationComments/CrefTests.cs Outdated
var source = """
namespace System
{
public class TypeA
Copy link
Contributor

@CyrusNajmabadi CyrusNajmabadi Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot makes these non-public, so you don't have to have the warning diagnostics about missing xml doc comments.

Copy link
Contributor Author

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 3effaa8

@CyrusNajmabadi
Fix WorkItem attribute to reference correct issue number 4031
eaef250 
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Copilot AI requested a review from CyrusNajmabadi November 11, 2025 00:05
@CyrusNajmabadi
Make test classes non-public to avoid missing XML doc warnings
3effaa8 
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review November 11, 2025 09:56
@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner November 11, 2025 09:56
jjonescz
jjonescz approved these changes Nov 11, 2025
View reviewed changes
@CyrusNajmabadi
Add test for ambiguous method references with parameters
ab0f146 
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Copilot AI requested a review from CyrusNajmabadi November 11, 2025 14:31
@CyrusNajmabadi CyrusNajmabadi marked this pull request as draft November 11, 2025 14:44
@CyrusNajmabadi CyrusNajmabadi marked this pull request as ready for review November 11, 2025 15:02
@CyrusNajmabadi
Copy link
Contributor

CyrusNajmabadi commented Nov 11, 2025

@RikkiGibson ptal.

@CyrusNajmabadi CyrusNajmabadi merged commit 8519dcf into main Nov 11, 2025
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Nov 11, 2025
@CyrusNajmabadi CyrusNajmabadi deleted the copilot/fix-ambiguous-reference-cs0419 branch November 12, 2025 06:31
@dotnet-bot dotnet-bot mentioned this pull request Nov 14, 2025
Closed
@dotnet-maestro dotnet-maestro bot mentioned this pull request Dec 18, 2025
Merged
@davidwengier davidwengier modified the milestones: Next, 18.3 Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjonescz jjonescz jjonescz approved these changes

@RikkiGibson RikkiGibson RikkiGibson approved these changes

@CyrusNajmabadi CyrusNajmabadi Awaiting requested review from CyrusNajmabadi

Assignees

@CyrusNajmabadi CyrusNajmabadi

Copilot code review Copilot

Labels

Area-Compilers

Projects

None yet

Milestone

18.3

Development

Successfully merging this pull request may close these issues.

Include fully qualified references in CS0419 to make it less confusing

5 participants

@CyrusNajmabadi @jjonescz @RikkiGibson @davidwengier