Add order attribute to PeekableItemSourceProvider#81095
Merged
dibarbet merged 1 commit intodotnet:mainfrom Nov 7, 2025
Merged
Conversation
dotnet#80951 slightly broke Peek Definition by making editor pick VS LSP client implementation of IPeekableSourceProvider instead of this one. Similarly to command handlers this provider also needs to be ordered before LSP's one.
dibarbet
approved these changes
Nov 7, 2025
Member
dibarbet
left a comment
There was a problem hiding this comment.
ah i should havve seen this one - thanks
CyrusNajmabadi
approved these changes
Nov 7, 2025
Contributor
Author
|
@dibarbet can you please rerun failing checks and merge the PR? I have no permissions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#80951 slightly broke Peek Definition by making editor pick VS LSP client implementation of IPeekableSourceProvider instead of this one. Similarly to command handlers this provider also needs to be ordered before LSP's one.