Remove parameters which are redundant with _localScopeDepth#81045
Merged
RikkiGibson merged 10 commits intodotnet:mainfrom Nov 11, 2025
Merged
Remove parameters which are redundant with _localScopeDepth#81045RikkiGibson merged 10 commits intodotnet:mainfrom
RikkiGibson merged 10 commits intodotnet:mainfrom
Conversation
RikkiGibson
commented
Nov 6, 2025
333fred
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #80682
Additionally, I removed property
BoundCapturedReceiverPlaceholder.LocalScopeDepth, because it should always be the same as_localScopeDepth, when the expression is visited inGetRefEscape/GetValEscape/CheckRefEscape/CheckValEscape. Essentially, that node is created and used temporarily while analyzing a call in this same pass, in order to signal that a ref to the receiver argument, is really to a temp in the current scope. There is no ability for the local scope depth to change in the middle of that.