Better handle if a BuildHost process crashes that prevents connection#81041
Merged
jasonmalinowski merged 2 commits intodotnet:mainfrom Nov 5, 2025
Conversation
When we switched over to using named pipes to connect to the BuildHost process, we lost our handling of a BuildHost process crashing right away. This restores the logging logic so we can log the stdout and stderr of the process to understand the root cause.
dibarbet
approved these changes
Nov 5, 2025
JoeRobich
reviewed
Nov 5, 2025
| } | ||
|
|
||
| public RemoteBuildHost BuildHost { get; } | ||
| public RemoteBuildHost BuildHost =>_buildHost ?? throw new InvalidOperationException("Build host is not connected."); |
Member
There was a problem hiding this comment.
Should _buildHost get cleared anywhere? Process_Exited or DisposeAsync?
Member
Author
There was a problem hiding this comment.
We could, I'm not sure to what end though. DisposeAsync() isn't using it -- at that point it's shutting down the _rpcClient, and we've already got null checking there.
JoeRobich
approved these changes
Nov 5, 2025
ec1aa45 to
d9d32cf
Compare
d9d32cf to
06141dd
Compare
This was referenced Nov 6, 2025
This was referenced Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we switched over to using named pipes to connect to the BuildHost process, we lost our handling of a BuildHost process crashing right away. This restores the logging logic so we can log the stdout and stderr of the process to understand the root cause.