Fix "Generate method" to add static modifier for function pointers by Copilot · Pull Request #80985 · dotnet/roslyn

Copilot · 2025-11-02T20:07:51Z

Fix "Generate method" to add `static` modifier for function pointers

Fixes: Function pointers can only point to static methods in C#, but the "Generate method" code fix was not adding the static modifier when invoked from a non-static context.

Implementation Summary

Problem:

unsafe class C
{
    private void M()
    {
        delegate* managed<void> x = &M2;  // Invoke "Generate method" on M2
    }
}

Before: Generated private void M2() (missing static, causes CS8759)
After: Generates private static void M2() ✅

Changes Made

Modified src/Analyzers/Core/CodeFixes/GenerateMember/AbstractGenerateMemberService.cs
- Updated TryDetermineTypeToGenerateInWorker to detect address-of contexts
- Added inline check: if expression parent is AddressOfExpression, force static
- Logic: if (!isStatic && expression.Parent != null && expression.Parent.RawKind == syntaxFacts.SyntaxKinds.AddressOfExpression)
Added test cases in src/Analyzers/CSharp/Tests/GenerateMethod/GenerateMethodTests.cs
- InferMethodFromAddressOfInNonStaticContext - simple name scenario &M2
- InferMethodFromAddressOfInNonStaticContextWithQualifiedName - qualified name scenario &C.M2

Key Improvements (from PR feedback)

Simplified logic: removed unnecessary type checking - if we're generating a method for address-of, it must always be static
Better parameter usage: leverage syntaxFacts.SyntaxKinds directly
Inlined simple helper method for clarity
Comprehensive test coverage: both simple and qualified name scenarios

Verification

Build: Compiles successfully with no errors
Code Review: All feedback from @CyrusNajmabadi addressed
Tests: Added comprehensive test coverage
Code Quality: Simplified implementation, clearer intent

Original prompt

This section details on the original issue you should resolve

<issue_title>"Generate method" does not add static modifier when generating method for function pointer</issue_title>
<issue_description>Version Used: VS 18.0.0 Insiders [11123.170]

Steps to Reproduce:
Invoke the lightbulb menu and select "Generate method 'M2'".
unsafe class C
{
    private void M()
    {
        delegate* managed<void> x = &M2;
    }
}
Expected Behavior:
The method is generated with the static modifier.

Actual Behavior:
The method is generated without the static modifier, leading to an error:
unsafe class C
{
    private void M()
    {
        delegate* managed<void> x = &M2; // CS8759: Cannot create a function pointer for 'C.M2()' because it is not a static method
    }

    private void M2()
    {
        throw new NotImplementedException();
    }
}
```</issue_description>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>

Fixes "Generate method" does not add static modifier when generating method for function pointer #80984

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

- Modified TryDetermineTypeToGenerateInWorker to detect address-of expressions used with function pointers - Added IsInFunctionPointerAddressOfContext helper method to check if expression is within address-of operator that targets a function pointer type - Added test case InferMethodFromAddressOfInNonStaticContext to verify fix works in non-static contexts Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>

- Updated IsInFunctionPointerAddressOfContext to access AddressOfExpression directly from ISyntaxKindsService (which inherits from ISyntaxKinds) - Fixed incorrect property access that was causing CS1061 error Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>

- Simplified IsInFunctionPointerAddressOfContext with early returns to reduce nesting - Removed redundant addressOfExpression variable and use expression.Parent directly - Improved code readability Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>

src/Analyzers/CSharp/Tests/GenerateMethod/GenerateMethodTests.cs

src/Analyzers/Core/CodeFixes/GenerateMember/AbstractGenerateMemberService.cs

CyrusNajmabadi · 2025-11-02T22:04:09Z

src/Analyzers/Core/CodeFixes/GenerateMember/AbstractGenerateMemberService.cs

+        if (syntaxKinds == null || expression.Parent.RawKind != syntaxKinds.AddressOfExpression)
+            return false;
+
+        var typeInfo = semanticModel.GetTypeInfo(expression.Parent, cancellationToken);


@copilot no need to do this type check. If we're ever generating a method for an adress-of operation, it must always be static no matter what

Removed the type check - now always returns true for address-of operations in fefc2ae

src/Analyzers/CSharp/Tests/GenerateMethod/GenerateMethodTests.cs

- Add WorkItem attribute to test method - Simplify IsInAddressOfContext to use syntaxFacts.SyntaxKinds - Remove unnecessary type check - address-of always requires static - Add test for qualified name scenario (&C.M2) Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>

CyrusNajmabadi · 2025-11-02T22:44:49Z

src/Analyzers/Core/CodeFixes/GenerateMember/AbstractGenerateMemberService.cs

+    {
+        // If we're generating a method for an address-of operation, it must always be static
+        return expression.Parent != null && expression.Parent.RawKind == syntaxFacts.SyntaxKinds.AddressOfExpression;
+    }


@copilot this method is too simple. Just inline it.

Inlined in 343d351e

@CyrusNajmabadi

The helper method was too simple, so inlined it directly into the condition check per feedback from @CyrusNajmabadi Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>

CyrusNajmabadi · 2025-11-03T16:59:37Z

@dotnet/roslyn-ide ptal.

Copilot AI self-assigned this Nov 2, 2025

Initial plan

5d065d2

Copilot AI assigned CyrusNajmabadi Nov 2, 2025

Copilot started work on behalf of CyrusNajmabadi November 2, 2025 20:08 View session

dotnet-policy-service bot added the VSCode label Nov 2, 2025

Copilot AI and others added 2 commits November 2, 2025 20:36

Copilot AI changed the title ~~[WIP] Fix generate method to include static modifier for function pointers~~ Fix "Generate method" to add static modifier for function pointers Nov 2, 2025

Copilot AI requested a review from CyrusNajmabadi November 2, 2025 20:46

Copilot finished work on behalf of CyrusNajmabadi November 2, 2025 20:46

CyrusNajmabadi reviewed Nov 2, 2025

View reviewed changes

Copilot started work on behalf of CyrusNajmabadi November 2, 2025 22:05 View session

Copilot AI requested a review from CyrusNajmabadi November 2, 2025 22:15

Copilot finished work on behalf of CyrusNajmabadi November 2, 2025 22:15

CyrusNajmabadi reviewed Nov 2, 2025

View reviewed changes

Copilot started work on behalf of CyrusNajmabadi November 2, 2025 22:45 View session

Inline IsInAddressOfContext method

343d351

The helper method was too simple, so inlined it directly into the condition check per feedback from @CyrusNajmabadi Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>

Copilot AI requested a review from CyrusNajmabadi November 2, 2025 22:54

Copilot finished work on behalf of CyrusNajmabadi November 2, 2025 22:54

CyrusNajmabadi approved these changes Nov 2, 2025

View reviewed changes

Only C#

df40f06

JoeRobich approved these changes Nov 3, 2025

View reviewed changes

CyrusNajmabadi marked this pull request as ready for review November 3, 2025 18:10

CyrusNajmabadi requested a review from a team as a code owner November 3, 2025 18:10

CyrusNajmabadi enabled auto-merge (squash) November 3, 2025 18:10

CyrusNajmabadi merged commit c9ed9bf into main Nov 3, 2025
24 of 25 checks passed

dotnet-policy-service bot added this to the Next milestone Nov 3, 2025

CyrusNajmabadi deleted the copilot/fix-generate-method-static-modifier branch November 3, 2025 19:17

dotnet-maestro bot mentioned this pull request Nov 4, 2025

[main] Source code updates from dotnet/roslyn dotnet/dotnet#3147

Closed

dotnet-bot mentioned this pull request Nov 6, 2025

[Automated] PRs inserted in VS build feature.servicehub.add-app-local-net10-11205.156 #81075

Closed

dotnet-maestro bot mentioned this pull request Nov 6, 2025

[release/10.0.2xx] Source code updates from dotnet/roslyn dotnet/dotnet#3244

Closed

dotnet-bot mentioned this pull request Nov 7, 2025

[Automated] PRs inserted in VS build feature.debugger.main-11206.224 #81096

Closed

dotnet-maestro bot mentioned this pull request Dec 18, 2025

[main] Source code updates from dotnet/roslyn dotnet/dotnet#3957

Merged

davidwengier modified the milestones: Next, 18.3 Jan 6, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix "Generate method" to add static modifier for function pointers#80985

Fix "Generate method" to add static modifier for function pointers#80985
CyrusNajmabadi merged 7 commits intomainfrom
copilot/fix-generate-method-static-modifier

Copilot AI commented Nov 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

CyrusNajmabadi Nov 2, 2025

Uh oh!

Copilot AI Nov 2, 2025

Uh oh!

Uh oh!

CyrusNajmabadi Nov 2, 2025

Uh oh!

Copilot AI Nov 2, 2025

Uh oh!

CyrusNajmabadi commented Nov 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Copilot AI commented Nov 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!