Skip to content

Rename GetIsNewExtensionMember helpers#80925

Merged
AlekseyTs merged 2 commits intodotnet:mainfrom
AlekseyTs:RenameGetIsNewExtensionMember
Oct 28, 2025
Merged

Rename GetIsNewExtensionMember helpers#80925
AlekseyTs merged 2 commits intodotnet:mainfrom
AlekseyTs:RenameGetIsNewExtensionMember

Conversation

@AlekseyTs
Copy link
Contributor

No description provided.

@AlekseyTs AlekseyTs requested review from jcouv and jjonescz October 28, 2025 00:16
@AlekseyTs AlekseyTs requested a review from a team as a code owner October 28, 2025 00:16
@AlekseyTs AlekseyTs added Area-Compilers Feature - Extension Everything The extension everything feature labels Oct 28, 2025

#nullable enable
internal static bool GetIsNewExtensionMember(this Symbol member)
internal static bool IsExtensionBlockMember(this Symbol member)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: We could even switch those helpers to be properties, which would go well with IsExtension and IsExtensionMethod

Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (commit 2)

@jcouv jcouv self-assigned this Oct 28, 2025
@AlekseyTs AlekseyTs requested a review from a team October 28, 2025 13:54
@AlekseyTs
Copy link
Contributor Author

@jjonescz, @dotnet/roslyn-compiler For a second review

@AlekseyTs AlekseyTs merged commit 53890ee into dotnet:main Oct 28, 2025
25 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Oct 28, 2025
@davidwengier davidwengier modified the milestones: Next, 18.3 Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Compilers Feature - Extension Everything The extension everything feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants