Fix documentation: clarify #error version requires compiler version, not language version#80787
Merged
CyrusNajmabadi merged 2 commits intomainfrom Nov 6, 2025
Merged
Conversation
…version Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix incorrect information in troubleshooting markdown file
Fix documentation: clarify #error version requires compiler version, not language version
Oct 16, 2025
Contributor
|
@RikkiGibson does this look correct? |
CyrusNajmabadi
approved these changes
Nov 6, 2025
dibarbet
approved these changes
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the incorrect information in
docs/wiki/Troubleshooting-tips.mdabout the#error versionfeature.Issue
The documentation stated that
#error version"only works with C# 7.1 or later", which was misleading because it's a compiler feature, not a language version requirement.Changes
Updated the note from:
To:
Rationale
The
#error versionfeature:TestErrorWithVersionin the test suite)The compiler version 2.3 happens to be the first version that supported C# 7.1 as a language version, but the feature itself doesn't depend on the language version being set to 7.1 - it works regardless of what language version you're targeting.
Fixes #76835
Original prompt
Fixes #47084
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.