Add regeneration instructions to VB Syntax.xml#80703
Merged
Conversation
Co-authored-by: CyrusNajmabadi <4564579+CyrusNajmabadi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add instructions to regenerate compiler code in XML files
Add regeneration instructions to VB Syntax.xml
Oct 14, 2025
CyrusNajmabadi
approved these changes
Oct 14, 2025
jcouv
approved these changes
Oct 14, 2025
This was referenced Oct 17, 2025
This was referenced Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where developers editing
Syntax.xmlandBoundNodes.xmlfiles had no clear instructions on what to do after making changes to regenerate the compiler code.Problem
When developers modify the XML files that define syntax trees and bound nodes for the compiler, the generated code is not automatically updated. Previously, only three of the four XML files had comments indicating that
eng/generate-compiler-code.cmdneeds to be run after making changes. The Visual BasicSyntax.xmlfile was missing this crucial instruction.Solution
Added an XML comment to
src/Compilers/VisualBasic/Portable/Syntax/Syntax.xmlinstructing developers to runeng/generate-compiler-code.cmdafter making changes:The comment was placed immediately after the license header, following the same pattern used in:
All four XML files now have consistent documentation for developers.
Fixes #15470
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
6s7vsblobprodcus313.vsblob.vsassets.iodotnet run --file eng/generate-compiler-code.cs(dns block)7tjvsblobprodcus341.vsblob.vsassets.iodotnet run --file eng/generate-compiler-code.cs(dns block)lylvsblobprodcus31.vsblob.vsassets.iodotnet run --file eng/generate-compiler-code.cs(dns block)pe3vsblobprodcus354.vsblob.vsassets.iodotnet run --file eng/generate-compiler-code.cs(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
Fixes #22331
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.