Avoid deep recursion in PatternExplainer.VisitPathsToNode#80685
Merged
AlekseyTs merged 2 commits intodotnet:mainfrom Oct 14, 2025
Merged
Avoid deep recursion in PatternExplainer.VisitPathsToNode#80685AlekseyTs merged 2 commits intodotnet:mainfrom
AlekseyTs merged 2 commits intodotnet:mainfrom
Conversation
RikkiGibson
reviewed
Oct 13, 2025
| if (!exploreToNode(test.WhenFalse, currentRequiresFalseWhenClause)) | ||
| return false; | ||
| } | ||
| continue; |
Member
There was a problem hiding this comment.
Remove trailing whitespace to make formatter happy
Suggested change
| continue; | |
| continue; |
RikkiGibson
reviewed
Oct 13, 2025
| { | ||
| if (!exploreToNode(test.WhenTrue, currentRequiresFalseWhenClause)) | ||
| return false; | ||
| stack.Count = stackSize; |
Member
There was a problem hiding this comment.
What is setting the count in this way doing? I guess it is like reverting the stack contents to how they were before the current call to exploreToNode?
Contributor
Author
There was a problem hiding this comment.
What is setting the count in this way doing? I guess it is like reverting the stack contents to how they were before entering the
do {...}?
The intent is to reset the stack to the state it was in when we entered the function.
333fred
approved these changes
Oct 13, 2025
RikkiGibson
approved these changes
Oct 14, 2025
This was referenced Oct 17, 2025
This was referenced Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #80569